Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13885] - [imp] Added a validation message for the URL field when schema is not provided

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar marrouchi
marrouchi
3 Feb 2017

Pull Request for Issue #13870.

Summary of Changes

Added a validation message to the JFormRuleUrl class.

Testing Instructions

  1. Create a url field : fill schema and make sure it's not relative
  2. Create a new content and fill the url field with a domain name (example.com).

Expected result

A warning message displays "Invalid URL : URL schema is missing in example.com. Please add one of the following at the begining : http...." with no explanation.

Actual result

A warning message displays "Invalid field" with no explanation.

Documentation Changes Required

No.

avatar marrouchi marrouchi - open - 3 Feb 2017
avatar marrouchi marrouchi - change - 3 Feb 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Feb 2017
Category ⇒ Administration Language & Strings Libraries
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Feb 2017

I have tested this item ✅ successfully on c0048b4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13885.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 3 Feb 2017 - Tested successfully
avatar marrouchi marrouchi - change - 3 Feb 2017
Labels Added: ? ?
avatar justinherrin
justinherrin - comment - 3 Feb 2017

Just a minor spelling typo to correct...
"Invalid URL : URL schema is missing in %s. Please add one of the following at the begining : %s."

Should be...
"Invalid URL : URL schema is missing in %s. Please add one of the following at the beginning : %s."

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 22 Feb 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Feb 2017

I have tested this item ✅ successfully on c1636c2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13885.

avatar infograf768
infograf768 - comment - 28 Feb 2017

Please use ordered variables in the string
"Invalid URL : URL schema is missing in %1$s. Please add one of the following at the beginning : %2$s ."

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13885.
avatar infograf768 infograf768 - test_item - 1 Mar 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 1 Mar 2017

I have tested this item ✅ successfully on 19a0e9f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13885.

avatar marrouchi
marrouchi - comment - 1 Mar 2017

RTC please

avatar infograf768 infograf768 - change - 1 Mar 2017
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 1 Mar 2017

RTC as the change in the string concerns only the type of variable.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13885.

avatar wilsonge wilsonge - change - 1 Mar 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-03-01 14:09:30
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 1 Mar 2017
avatar wilsonge wilsonge - merge - 1 Mar 2017

Add a Comment

Login with GitHub to post a comment