J3 Issue ?
avatar PhilETaylor
PhilETaylor
2 Feb 2017

Steps to reproduce the issue

install 3.7.0b1
create Url(Url) custom field
Set scheme to be http://
edit content on FRONTEND
attempt to bypass validation

Expected result

http:// this is & not & a VALID url should not be saveable and should error

Actual result

http:// this is & not & a VALID url saves as a valid url and is hyperlinked on rendering

Additional comments

If there is no validation on the URL then this custom field type is nothing more than a text field with "validate the first few char" and not a URL field!!! Either name it correctly or implement correct validation of the input !

avatar PhilETaylor PhilETaylor - open - 2 Feb 2017
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Feb 2017
avatar PhilETaylor PhilETaylor - edited - 2 Feb 2017
avatar Bakual
Bakual - comment - 2 Feb 2017

That is actually not related to com_fields as the same happens when you enter it into the link fields in an article. So I think the JFormFieldUrl itself would need to be fixed here.

avatar PhilETaylor
PhilETaylor - comment - 2 Feb 2017

Actually - if you are going to provide a URL field - it MUST validate as a url else whats the point. So it is related to com_fields in that respect.

avatar Bakual
Bakual - comment - 2 Feb 2017

The URL field extends JFormFieldUrl. So you don't need to fix it in the field plugin, you need to fix it in the old and existing formfield.
link

It's an old bug you found here ?

avatar PhilETaylor
PhilETaylor - comment - 27 Mar 2017

The only thing that makes a URL field different to a TEXT field, is that is SHOULD only accept a URL, effectively it should be a TEXT field with validation.... At the moment that is not being done so a URL field is only as good as a TEXT field

So is the correct course of action to remove the URL field type completely - losing yet another new feature?

or fix the fact that validation has been broken for years?

avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2017
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 27 Mar 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Mar 2017
Category com_fields
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2017
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 30 Mar 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Apr 2017
Category com_fields com_content com_fields
avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Apr 2017
Status New Needs Review
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Apr 2017

set Staus on "Needs Review" on issue Tracker.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13876.

avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Nov 2017
Title
[3.7.0b1] [com_fields] URL Field doesnt validation if the URL supplied is valid URL
[com_fields] URL Field doesnt validation if the URL supplied is valid URL
avatar joomla-cms-bot joomla-cms-bot - edited - 7 Nov 2017
avatar brianteeman brianteeman - change - 25 Mar 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar brianteeman brianteeman - change - 18 Aug 2018
Title
[com_fields] URL Field doesnt validation if the URL supplied is valid URL
URL Field doesnt validation if the URL supplied is valid URL
avatar brianteeman brianteeman - edited - 18 Aug 2018
avatar PhilETaylor PhilETaylor - change - 10 Feb 2019
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2019-02-10 21:35:06
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 10 Feb 2019

Add a Comment

Login with GitHub to post a comment