? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
2 Feb 2017

Summary of Changes

Adds a new plugin to help inserting the new {field ID} and {fieldgroup ID} tags.
It's based on the loadmodule editor plugin.
The button only shows if there are any fields which could be inserted.

Testing Instructions

  • Discover and enable the new "Button - Fields" plugin.
  • Go to eg an article and see the new editor button
    button
  • Click the button which opens the modal
    modal
  • Select either a field or the group and check that the correct tag is entered into the editor

Documentation Changes Required

Don't know

Notes

The button only shows if there are any fields which could be inserted. If there are none for a given context, then the button isn't shown. The context is guessed based on the active component (option) and view and the validated using the FieldHelper.

avatar Bakual Bakual - open - 2 Feb 2017
avatar Bakual Bakual - change - 2 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2017
Category SQL Administration com_admin Postgresql MS SQL com_fields Language & Strings Installation Front End Plugins
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Feb 2017

I have tested this item successfully on f89da5e

- tested on fields and -groups

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 3 Feb 2017 - Tested successfully
avatar ghazal
ghazal - comment - 3 Feb 2017

I have tested this item successfully on f89da5e

BTW, you should mention this:
"The button only shows if there are any fields which could be inserted."
above the image in this PR.
And in the description.
Don't forget some ppl are lazy ... and often don't read the small notes. Like me ¯_(ツ)_/¯ .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13875.

avatar ghazal ghazal - test_item - 3 Feb 2017 - Tested successfully
avatar laoneo
laoneo - comment - 3 Feb 2017

When I put in {fieldgroup 17823} and there is no fieldgroup with the id 17823, then it leaves the code in the article. Should this not being removed? The same happens with {field 123312}.

avatar Bakual Bakual - change - 3 Feb 2017
The description was changed
avatar Bakual Bakual - edited - 3 Feb 2017
avatar Bakual
Bakual - comment - 3 Feb 2017

When I put in {fieldgroup 17823} and there is no fieldgroup with the id 17823, then it leaves the code in the article. Should this not being removed? The same happens with {field 123312}.

Yeah, could be done for sure. Not sure what is more helpful in the end. The current way the admin sees that something is wrong. When we just rmeove it he may be wondering more why it didn't work. Haven't tried yet what happens in the loadmodule when the module isn't found :)

avatar Bakual Bakual - change - 3 Feb 2017
Labels Added: ? ?
avatar Bakual
Bakual - comment - 3 Feb 2017

@laoneo See #13898 for removing the plugin tag if the ID is invalid.

avatar rdeutz rdeutz - change - 4 Feb 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-04 21:01:26
Closed_By rdeutz
avatar rdeutz rdeutz - close - 4 Feb 2017
avatar rdeutz rdeutz - merge - 4 Feb 2017

Add a Comment

Login with GitHub to post a comment