? ? Pending

User tests: Successful: Unsuccessful:

avatar tomekstach
tomekstach
2 Feb 2017

I don't know why in the query #__tags is twice. Once as a a and second time as a b. For me it works perfectly when we remove b. I had a problem with this - for 1100 tags on my websites, Smart Search Indexer found more than 1233000 items to index.

Pull Request for Issue #13866.

Summary of Changes

Remove #__tags AS b from the query and change the b.created_user_id to the a.created_user_id in the JOIN part of the query.

Testing Instructions

Use php cli/finder_indexer.php to check if the number of tags is the same as a number of items to index.

Expected result

For the number of tags have the same number of items for index.

Actual result

For 1100 tags, I have more than 1233000 items to index.

Documentation Changes Required

avatar tomekstach tomekstach - open - 2 Feb 2017
avatar tomekstach tomekstach - change - 2 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2017
Category Front End Plugins
avatar tomekstach tomekstach - change - 3 Feb 2017
Labels Added: ?
avatar Hackwar
Hackwar - comment - 21 May 2018

I can confirm this issue and tested this item successfully.

avatar Hackwar
Hackwar - comment - 21 May 2018

I have tested this item successfully on ac3aa12


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13868.

avatar Hackwar Hackwar - test_item - 21 May 2018 - Tested successfully
avatar Quy
Quy - comment - 22 May 2018

I have tested this item successfully on ac3aa12


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13868.

avatar Quy Quy - test_item - 22 May 2018 - Tested successfully
avatar Quy Quy - change - 22 May 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 22 May 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13868.

avatar ggppdk
ggppdk - comment - 22 May 2018

I have tested this item successfully on ac3aa12

Tag indexing works properly
and

before PR we get FROM #__tags AS a, #__tags AS b
a million rows to index for 1000 tags

SELECT a.id, ...
	FROM #__tags AS a, #__tags AS b
	LEFT JOIN #__users AS u ON u.id = b.created_user_id
	WHERE `a`.`id` > 1

After PR FROM #__tags AS a
1000 rows to index for 1000 tags

SELECT a.id, ...
	FROM #__tags AS a
	LEFT JOIN #__users AS u ON u.id = a.created_user_id
	WHERE `a`.`id` > 1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13868.
avatar ggppdk ggppdk - test_item - 22 May 2018 - Tested successfully
avatar mbabker mbabker - close - 24 May 2018
avatar mbabker mbabker - merge - 24 May 2018
avatar mbabker mbabker - change - 24 May 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-24 00:06:28
Closed_By mbabker
Labels Added: ?

Add a Comment

Login with GitHub to post a comment