Feeling Lucky
?
[#13867] - [3.7.0b1] [com_fields] Errors when using invalid SQL
- Closed
- 3 Feb 2017
- Medium
- Build: staging
- # 13867
Steps to reproduce the issue
Create a new field of type SQL
Input some crap instead of a SQL (or a sql that doesn't return text and value values)
Expected result
basic validation on saving the field to ensure text and value are strings in the sql input
No errors output to the screen
Actual result
Notice: Undefined property: stdClass::$value in /Users/phil/Downloads/Joomla_3.7.0-beta1-Beta-Full_Package/libraries/joomla/form/fields/sql.php on line 298
Notice: Undefined property: stdClass::$text in /Users/phil/Downloads/Joomla_3.7.0-beta1-Beta-Full_Package/libraries/joomla/form/fields/sql.php on line 298
System information (as much as possible)
Mysql
joomla-cms-bot
- | Labels |
Added:
?
|
||
marrouchi
- comment
- 3 Feb 2017
I was unable to reproduce the issue ...
laoneo
- comment
- 3 Feb 2017
Did you follow the instructions on the pr?
marrouchi
- comment
- 3 Feb 2017
Yes
zero-24
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-03 17:40:43 |
| Closed_By | ⇒ | zero-24 |
Needs to be fixed in JFormFieldSql then. Or how would you want to sanitizse the input in the field itself? The input will always be a string and the formfield will only know if it's valid SQL when it tries to run it against the database.
However imho it's fine to show an error.
It's not like a visitor is going to create such fields, it's an admin type (site integrator, or similar) who will create those and it will be helpful for him to see the errors.