Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13857] - Fixes the issue which causes custom menu items to be lost on component update

? ? Success

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
2 Feb 2017

Pull Request for Issue #13642.

Summary of Changes

  1. Changed \JInstallerAdapterComponent::_removeAdminMenus to remove only the protected menu items, i.e. - menutype == 'main' and leave alone other menutypes.
  2. Replicated \JInstallerAdapterComponent::_updateSiteMenus as \JInstallerAdapterComponent::_updateMenus to update the admin menus as well.

Testing Instructions

  1. Create a custom admin menu.
  2. Install any extension.
  3. Create a menu link for the component in your custom menu.
  4. Reinstall/update your component.

Extra: Uninstall your component. The menu item should still exist in your custom admin menu, though orphaned.

Expected result

The custom menu item in step 3 above, should still point to the same component.

Actual result

Without this patch The custom menu item in step 3 above is removed. After this patch, we get the expected result.

Documentation Changes Required

None

Pinging @rdeutz @infograf768 @Bakual

avatar izharaazmi izharaazmi - open - 2 Feb 2017
avatar rdeutz rdeutz - change - 2 Feb 2017
Milestone Added:
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Feb 2017

Tested successfully (Item not found at Issue Tracker).

Test using Sermonspeaker installing, uninstalling, reinstalling (not tested on Update). All works like described in Instructions.

avatar rdeutz
rdeutz - comment - 2 Feb 2017

It seems there is a problem with the issue tracker, I added the PR-Staging label manuell.

Could you @mbabker have a lock when you have a minute

avatar rdeutz
rdeutz - comment - 2 Feb 2017

I also tested it successfully

avatar mbabker
mbabker - comment - 2 Feb 2017

There's already a tracking issue... joomla/jissues#939

avatar mbabker mbabker - alter_testresult - 2 Feb 2017 - franz-wohlkoenig: Tested successfully
avatar mbabker mbabker - change - 2 Feb 2017
Status New ⇒ Ready to Commit
avatar mbabker
mbabker - comment - 2 Feb 2017

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13857.

avatar mbabker mbabker - alter_testresult - 2 Feb 2017 - rdeutz: Tested successfully
avatar Kubik-Rubik
Kubik-Rubik - comment - 2 Feb 2017

Thank you @izharaazmi and testers!

avatar Kubik-Rubik Kubik-Rubik - merge - 2 Feb 2017
avatar Kubik-Rubik Kubik-Rubik - change - 2 Feb 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-02-02 18:48:16
Closed_By ⇒ Kubik-Rubik
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - close - 2 Feb 2017
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2017
Category ⇒ Libraries External Library
avatar izharaazmi
izharaazmi - comment - 2 Feb 2017

@rdeutz I am going to propose a little improvement tomorrow. After beta release it might not be possible to get it in 3.7. Could you please wait to atleast see it before you mark the beta release.

avatar rdeutz
rdeutz - comment - 2 Feb 2017

@izharaazmi I am preparing the beta release just now, we have a beta2 next week, if it makes sense we will add it.

Add a Comment

Login with GitHub to post a comment