[#13856] - Display a warning whenever an menu item's alias has changed
- Closed
- 30 Jun 2019
- Medium
- Build: staging
- # 13856
- Diff
- marrouchi:staging-new-plugin
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Failure JTracker/HumanTestResults Human Test Results: 0 Successful 4 Failed. Details
User tests: Successful: Unsuccessful:
Display a warning message whenever a menu item's alias has been updated. The message suggests to the admin user to create a new redirection to the old alias in order to avoid 404 errors from existing urls.
Pull Request for Issue #13851.
Summary of Changes
- Added two methods to the redirect plugin:
- onContentbeforeSave : Check if the menu item's alias has changed. If it's the case, then display a warning message that suggests to the admin user to create a redirection to the old alias.
- onContentPrepareForm : Alter menu item edit form whenever there's GET params (old_alias & new_alias) in order to set default values for the fields
old_url&new_url
- An enable/disable field (
Watch Alias) has been added to the plugin config form if there's need a disable this feature.
Testing Instructions
First, make sure that the redirect plugin is enabled.
When enabled :
- Edit an existing menu item and change the alias. Then hit the Save button.
- A warning message should be displayed that says : "You should create a new redirection to avoid 404 errors that could be generated by the old alias's urls : Create a new redirection"
- Click on the link Create a new redirection and you should be redirected to a new redirection form with the two fields
old_url&new_urlfilled with default values. Hit the Save button. - Access the old URL in frontend (that uses the old alias) and you should be redirected to the new one.
When disabled :
- Go the redirect plugin config form and disable
Watch Alias - Back to the menu manager, Edit an existing menu item and change the alias. Then hit the Save button.
- There will be no warning message.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings SQL Installation Postgresql MS SQL Front End Plugins |
@tonypartridge Yes i saw your issue and i've coded a PR right away :)
@marrouchi I am just wondering if a plugin is needed. Can we not just adjust the com_menus component? Since the plugin is called on every save when it is only needed on a menu item save.
I thought of this approach would be better to keep the menu item controller clean, since this feature is related to two components (com_menus & com_redirect).
I see your point completely, but it's then a plugin which is also then still requires both components. But both components ship with the core.
@zero-24 @mbabker what are your thoughts on this?
I was thinking of checking if com_redirects plugin is enabled and if so basically doing what Marrouchi has done. But within the component controller opposed to a plugin?
Why not throw it in the existing redirect plugin? The notice seems like a good idea to me and that plugin already has to be active to make use of the system, so...
Duhh good idea! @mbabker
@marrouchi do you want to do the changes?
Yes good idead ! Should i create a new PR ?
I don't think so? Just remove this plugin from your GIT and add the changes to the system and push your changes they should come through for us to review again.
One should only get a message or action link (whatever) if sef is enabled.
And there should be an option in the plugin to deactivate this feature completely, please. Because of other extensions that also deal with aliases.
I disagree re see as some people might disable it on testing environments when doing something or other. But an option to disable it is a good idea.
On 2 Feb 2017, 16:14 +0000, bertmert notifications@github.com, wrote:
One should only get a message or action link (whatever) if sef is enabled.
And there should be an option in the plugin to deactivate this feature completely, please. Because of other extensions that also deal with aliases.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#13856 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/ABVglvCy8DrGyuHBsTeH68yfez9HNSaZks5rYgDAgaJpZM4L1Pd0).
| Title |
|
||||||
| Labels |
Added:
?
?
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-02 17:06:39 |
| Closed_By | ⇒ | marrouchi |
| Category | Administration Language & Strings SQL Installation Postgresql MS SQL Front End Plugins | ⇒ |
| Labels |
Removed:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-02-02 17:06:39 | ⇒ | |
| Closed_By | marrouchi | ⇒ |
| Status | New | ⇒ | Pending |
| Category | ⇒ | Front End Plugins |
| Category | Front End Plugins | ⇒ | Administration Language & Strings Front End Plugins |
Done ! I've added a enable/disable button of this features in the redirect plugin config form.
Ready to test
| Title |
|
||||||
I have tested this item
Point 1-3 of Testing Instructions works.
Not working Point 4: Using old Url get redirected on Homepage. Using modern Router.
Another Point: If User have Redirect-Plugin disabled, they got no Hint.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13856.
@franz-wohlkoenig This PR does not alter the redirection mechanism. Redirection does not seem to work when modern routing is enabled and that's an new issue that must be addressed. To confirm this, please revert the patch and try a redirection when having modern routing enabled.
Test on legacy Router, Plugin "Redirect" enabled.
Got on Point 4 (using old alias using-joomla) a 404 Category not found. Category is enabled, in Plugin is a new, disabled Link index.php/using-joomla without new URL.
Test on:
Joomla! 3.7.0-beta1
macOS Sierra, 10.12.3
Firefox 50.1.0
PHP 7.0.4
MySQLi 5.5.53-0
| Labels |
Added:
?
|
||
Can you look at resolving the conflicts so that this can be tested please.
Yemetio
- 
I have tested this item
I apply the patch, watch alias was enabled
then i changed an existing menu item
but i got no warning message
@icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13856.
I have tested this item
I would love to have this feature, but i had an error on testing.
0 Using $this when not in object context
/Applications/MAMP/htdocs/joomla-cms/libraries/src/Application/CMSApplication.php:369
@Yemetio if you restest later open the plugin and save the settings
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13856.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13856.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13856.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13856.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests considering 2 unsuccessful tests so Maintainers have to decide (as always).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13856.
please remove the rtc status
| Status | Ready to Commit | ⇒ | Pending |
Removed RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13856.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13856.
@marrouchi
Can you change the Line I reviewed, and fix the Code Style for 3.8 ?
- Would be great to have this watcher also on trashing and on unpublishing the item.
Thank you for this great addition.
| Category | Front End Plugins Administration Language & Strings | ⇒ | Administration Front End Plugins |
| Title |
|
||||||
| Category | Front End Plugins Administration | ⇒ | Administration Language & Strings Front End Plugins |
Hi @marrouchi,
as this is a new feature it will not go into J3.x series because of the feature freeze. Also it seams it doesn't work (4 failing tests).
If you still interested to bring this feature into Joomla please rebase the PR on J4 branch and correct the reported errors.
Thx for your work and time you invested into Joomla! I'm closing this PR and hope you find time to create a new one for J4.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-30 22:59:53 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Removed:
J3 Issue
|
||
@marrouchi great minds think a like ;-) I just created an issue today about this
issue #13851
I was thinking of going one step further and auto-creating the redirect if a user wishes. I'll run some tests on this.