Feeling Lucky
?
[#13846] - Replace ternary with implicit conditional call
- Closed
- 1 Feb 2017
- Medium
- Build: staging
- # 13846
- Diff
- tfrommen:patch-1
User tests: Successful: Unsuccessful:
Summary of Changes
Hey there,
this pull request replaces the (strange) ternary (which should basically serve as an if expression) with an implicit conditional function call; two times. :)
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
joomla-cms-bot
- | Category | ⇒ | Administration |
Bakual
- comment
- 1 Feb 2017
Imho, current code is more readable. Allthough a real if clause would probably be even more readable in that case.
Your suggestion does look like kind of a hack to me even if it works.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-01 23:02:07 |
| Closed_By | ⇒ | tfrommen |
IMHO you can do the same for all joomla files.