? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
1 Feb 2017

Pull Request for Issue #13820 & #13768 .

Summary of Changes

The Joomla LESS compiler returns incorrect values for the row-fluid Bootstrap grid. This PR replaces these with the correct values within the Isis admin template.

I realise that the ideal solution is to fix the compiler however I don't think this option is available and replacing the compiler is unlikely until 4.0.

Testing Instructions

Apply patch. Navigate to article edit and resize the browser window...

Before Patch

grid1

After Patch

grid2

Documentation Changes Required

None

avatar ciar4n ciar4n - open - 1 Feb 2017
avatar ciar4n ciar4n - change - 1 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Feb 2017
Category Administration Templates (admin)
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Feb 2017

I have tested this item successfully on a0e60cd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13845.

avatar ciar4n ciar4n - edited - 1 Feb 2017
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 1 Feb 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 1 Feb 2017

I have tested this item successfully on a0e60cd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13845.

avatar infograf768 infograf768 - test_item - 1 Feb 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 1 Feb 2017

@ciar4n
While testing, I found an issue with the YesNo buttons in RTL, all over core.
Can you look at it?
screen shot 2017-02-01 at 16 49 41

avatar ciar4n
ciar4n - comment - 2 Feb 2017

Thank you for the tests.

@infograf768 Thank you.. I'll submit a PR to fix

avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2017
Title
[Isis] Bypass lessc row-fluid calculations
[Isis] Replace lessc row-fluid calculations
avatar joomla-cms-bot joomla-cms-bot - edited - 2 Feb 2017
avatar infograf768 infograf768 - change - 2 Feb 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 2 Feb 2017

RTC.

@mbabker A last look?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13845.

avatar ciar4n ciar4n - change - 2 Feb 2017
Title
[Isis] Replace lessc row-fluid calculations
[Isis] Bypass lessc row-fluid calculations
avatar ciar4n ciar4n - edited - 2 Feb 2017
avatar wilsonge wilsonge - change - 2 Feb 2017
Title
[Isis] Bypass lessc row-fluid calculations
[Isis] Replace lessc row-fluid calculations
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-02 13:26:02
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 2 Feb 2017
avatar wilsonge wilsonge - merge - 2 Feb 2017

Add a Comment

Login with GitHub to post a comment