? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
1 Feb 2017

Pull Request for Issue # .

Summary of Changes

This PR migrated the views to Bootstrap 4 and uses the new save group toolbar dropdown.

avatar C-Lodder C-Lodder - open - 1 Feb 2017
avatar C-Lodder C-Lodder - change - 1 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Feb 2017
Category Administration com_fields Templates (admin) Layout JavaScript
avatar C-Lodder C-Lodder - change - 1 Feb 2017
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Feb 2017

after applied Patch in Patch Tester: The file marked for modification does not exist: administrator/components/com_fields/views/field/tmpl/modal.php

avatar C-Lodder
C-Lodder - comment - 1 Feb 2017

Are you sure you're trying to apply this patch on the 4.0-dev branch?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Feb 2017

applied on 3.7-staging cause don't know if PR is for 3.7 or 4.

avatar C-Lodder
C-Lodder - comment - 1 Feb 2017

ahh sorry, forgot to mention that in the title. Updated it

avatar C-Lodder C-Lodder - change - 1 Feb 2017
Title
[com_fields] Migrate to Bootstrap 4
[com_fields] [J4.0] Migrate to Bootstrap 4
avatar C-Lodder C-Lodder - edited - 1 Feb 2017
avatar C-Lodder C-Lodder - change - 1 Feb 2017
Title
[com_fields] [J4.0] Migrate to Bootstrap 4
[4.0 - com_fields] Migrate to Bootstrap 4
avatar C-Lodder C-Lodder - edited - 1 Feb 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Feb 2017

@C-Lodder thanks for updating.

avatar wilsonge wilsonge - change - 1 Feb 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-01 13:41:05
Closed_By wilsonge
avatar wilsonge wilsonge - close - 1 Feb 2017
avatar wilsonge wilsonge - merge - 1 Feb 2017
avatar mahagr
mahagr - comment - 1 Feb 2017

Great.. So instead of hard coded Bootstrap 2 support Joomla will in the future have hard coded Bootstrap 4 support with no way to override it...

I thought that Joomla is going to move everything to layout files in order to avoid the same situation it had with J! 1.5, 2.5 & 3.x: painful template upgrades and old looks because of it is locked to a single version of a single CSS framework.

PS. I'm not a fan of having HTML inside any PHP code.

avatar mbabker
mbabker - comment - 1 Feb 2017

Umm, everything is in layouts except for the form XML definitions? Or am I missing something here?

avatar mahagr
mahagr - comment - 1 Feb 2017

@mbabker

Oh, nevermind then, I guess I'm just too used to see twig files instead of PHP files as templates.

avatar mbabker
mbabker - comment - 1 Feb 2017

Plain PHP's still a valid templating engine (just ask the Plates devs), but yeah, Twig is much nicer ?

Add a Comment

Login with GitHub to post a comment