? Pending

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
1 Feb 2017

Summary of Changes

If no container is defined in the active admin menu, force default container

Testing Instructions

  • Create a custom admin menu
  • Set it as your active menu in menu module settings.
  • It should show a container menu item with all components similar to that of "Components" menu in the default Joomla admin menu.
  • Create a new menu item of type "System Links > Components Menu Container" in your custom menu.
  • The default container should disappear and your custom container should show up.

Documentation Changes Required

None

Pinging @infograf768

avatar izharaazmi izharaazmi - open - 1 Feb 2017
avatar izharaazmi izharaazmi - change - 1 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Feb 2017
Category Modules Administration
avatar infograf768
infograf768 - comment - 1 Feb 2017

I have tested this item successfully on 617ef54


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13838.

avatar infograf768 infograf768 - test_item - 1 Feb 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 1 Feb 2017

To test, it is better to first patch with
#13830

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Feb 2017

@infograf768 #13830 is applied, apply this PR too got The patch could not be applied because it conflicts with a previously applied patch: administrator/modules/mod_menu/menu.php

avatar mbabker
mbabker - comment - 2 Feb 2017

Patch tester won't let you apply multiple patches to one file. It doesn't know how to handle that.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Feb 2017

thanks @mbabker i thought @infograf768 mean to apply #13830 and #13838 #

avatar infograf768
infograf768 - comment - 2 Feb 2017

well, you may have to wait for #13830 to be merged before testing this one. I can do here as i do not use patchtester.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13838.

avatar izharaazmi
izharaazmi - comment - 2 Feb 2017

@rdeutz I think we need this too.

avatar rdeutz
rdeutz - comment - 2 Feb 2017

@franz-wohlkoenig can you give it a try, I merged #13830

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Feb 2017

I have tested this item successfully on 617ef54


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13838.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 2 Feb 2017 - Tested successfully
avatar rdeutz rdeutz - change - 2 Feb 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-02 16:57:31
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 2 Feb 2017
avatar rdeutz rdeutz - merge - 2 Feb 2017

Add a Comment

Login with GitHub to post a comment