Are there some params somewhere that I have to delete to test this on an updated staging?

Forget it, I have the same results on a clean install.

Results of first round of tests for the Components Container:

The checkboxes are inverted: checked should usually Show instead of Hide.
There is no Tip showing when displaying Menu Selection which makes it confusing.
I think it should in fact not be a bubble tip but a permanent Notice.

For Menu Items Manager:
The checkboxes and other columns like status, etc, are displayed when filtering by Main (Protected) 'menutype'.
No permanent tip/text to explain what is that 'menutype'

Language strings.
Some lang strings values look obsolete and should be updated:
Example: COM_MENUS_ITEM_FIELD_COMPONENTS_CONTAINER_DESC="Choose whether this should be a container for the components menu created during installation of new components.<br><br>To hide any or all of those menu items from this container you can just unpublish them under the menu type: <strong>Main</strong> (protected)."

Others don't look like they are used
COM_MENUS_ITEM_FIELD_COMPONENTS_CONTAINER_HIDE_ITEMS_LABEL="Items to Hide"

The checkboxes are inverted: checked should usually Show instead of Hide.

We discussed this here #13739 (comment) and those follow it.

There is no Tip showing when displaying Menu Selection which makes it confusing.

Sorry, I forgot to put the label right. Fixed.

Removed the Protect Menu filter choice from the manager. No need to bother much about what user can't do anything with. Is that acceptable?

The checkboxes are inverted: checked should usually Show instead of Hide.

We discussed this here #13739 (comment) and those follow it.

I understand what you say but I still think that we should consider positive actions and not negative actions. I.e. by default all menu items to display should have the checkbox ticked as used elsewhere in core (assignments).

For the rest, looks fine here, including new components installed, assignments, display or not of the Component Container heading if all are set to hide.

@rdeutz @Bakual @wilsonge @laoneo
What do you think?
This is imho the last thing to decide for this feature before beta1

But NOT the last thing, we need to handle the component update issue too.
As of now, I am working on that.

But NOT the last thing

Right. ?

And maybe too forcing the creation of a Components Container to reply to nikosdion concerns in #13739

I don't know if this should be part of this PR as I got lost somewhere. But it is not possible anymore to edit the default menu (I guess you guys call it admin) like unpublishing components?

@laoneo

1. Create an admin menu and its module. Publish that module in Menu position.
2. Create menu items for this admin menu
   It should include a menu item to Modules Manager and one to Menu items Manager
3. Create a Components Menu Container (It is available in the modal under System links).
   It is there that you can choose which Components menu items will be displayed or not.
   
   

I'v checked all your test instructions and they are all fine. I'v tested it with the Free version of DPCalendar and it appears automatically in the Components Menu Container.

Edit/Publish/Unpublish/Delete/Trash/Batch toolbar buttons should not be displayed in menu manager when filtered by the protected menutype 'main'.

This is not possible anymore because the menu is not shown at all, or? Should we test it for some stuff which can break?

@laoneo Test instructions updated.

@laoneo
What we have to decide is #13830 (comment)
What do you think?

As I first opened this menu item. I expected it to select the components to show and not to hide.

As I first opened this menu item. I expected it to select the components to show and not to hide.

yep, that is also what I thought, thus my suggestion.
Let's wait other comments before asking @izharaazmi to change.

Gold solution would be to have it similar to the module manager.

I understand, and I too like it the other way around. But we have a
situation here. If we a list of items to "show" instead of "hide" then
after installation of a new component 'com_foo' we won't have 'com_foo' in
our list. This will cause 'com_foo' not being shown – as we only show the
already selected items and 'com_foo' wasn't selected. More confusion to the
users.

Any better solution is welcome, so far I do not have one. Thinking!

@infograf768 @laoneo Please see if it is now any better.

Looks good. ?
Maybe modify the label and desc values:
from

COM_MENUS_ITEM_FIELD_COMPONENTS_CONTAINER_HIDE_ITEMS_DESC="Select the menu items that should <strong>not be shown</strong> under this container. If there are no items to show, then this container will also be hidden.<br>Please note that when you install a new component it will be displayed by default until you come back here and select it too."
COM_MENUS_ITEM_FIELD_COMPONENTS_CONTAINER_HIDE_ITEMS_LABEL="Choose Items to Hide"

to something like

COM_MENUS_ITEM_FIELD_COMPONENTS_CONTAINER_HIDE_ITEMS_DESC="Select the menu items that should <strong>be shown or not</strong> under this container. If there are no items to show, then this container will also be hidden.<br>Please note that when you install a new component it will be displayed by default until you come back here and hide it too."
COM_MENUS_ITEM_FIELD_COMPONENTS_CONTAINER_HIDE_ITEMS_LABEL="Show or Hide Menu Items"

What do you think?

I did that and forgot to push it :D

@infograf768 Please check now.

Can't see Test button on issue.joomla.org.

Tested successfully here.

@mbabker

Can you solve the Test button issue?

@infograf768 Can see Test button. Had this one time, after re-login solved.

@franz-wohlkoenig

Does not work for me.

BTW, can you test this PR as well as https://issues.joomla.org/tracker/joomla-cms/13838 while keeping this patch.

Create a menutype 'menu', you should be able to create it without any warning after this patch. Without this patch a warning will be shown saying it is a reserved name.

works

> Menu manager menutype dropdown filter should no longer shown the options Menu (protected) and Main (protected).

what should "Menu manager menutype dropdown filter" show? I don't know which dropdown filter is meant.

Create a new custom admin menu and add a new menu item of type System Links > Components Menu Container.

1. Custom Menu is build:

2. Click on "Admin Custom" open:

3. "New" > "Menu Item Type" open

instead of

which i get by "Menus" > "Admin Custom" > "Add new Menu Item"

Where does this Admin-fw come from?

@izharaazmi
While making the glip for @franz-wohlkoenig I found a weird issue with Components Container. It could come from some settings here. Better to check though.
By default it displays here "modules" and "menu items"

It comes from the fact that I already created some menu items for these:

If I unpublish these, then they are not displayed anymore in the Components Container.

Can you please verify if no such menu items actually exists in your db by
going
here /administrator/index.php?option=com_menus&view=items&menutype=main or
in the database directly!

@izharaazmi
I found where the issue came from:
I had used the type "menu" for my customadmin menu

Once changed, all is fine.

I guess we still should prevent using "menu" as type...

Oh great. I had missed that at one place. It should now work fine. Please
go back and change it to 'menu' again and see if its correct now.

@izharaazmi
It will work if you correct the extraneous ( ?
It should not be:
->where('(m.menutype = ' . $db->q('main'))
but
->where('m.menutype = ' . $db->q('main'))
Once done, I will mark the test OK

So sorry! My bad!

OK now. Still can't get the Test button on issue.joomla.org

@infograf768 Admin-fw is the name of my custom admin-menu. Below a gif:

@franz-wohlkoenig
I suggest you test again on a clean staging. See above.

@infograf768 yes, staging installed today morning. Changes by @izharaazmi are not applied by Patchtester?

@franz-wohlkoenig Please note that your screenshot has only one dropdown (the menutype one) before search box. The client dropdown is missing. That is not correct.

See 1st image in #13830 (comment)

@izharaazmi have seen and made new install, latest staging, Patchtester update: Same Result and no "Access" in Menu Items:

Do you have these files in your installation?

administrator/components/com_menus/layouts/joomla/searchtools/default/bar.php
administrator/components/com_menus/layouts/joomla/searchtools/default.php

I have tested this item ✅ successfully on 982aaf6

wow... test works again

I'm testing on a live-Site and learned now, that "upload & update" latest staging install in an Folder as i thought it will update Installation.
So i will make daily a clean installation by latest staging.
Sorry for Confusing.

@izharaazmi there are no "Access-Levels"

@franz-wohlkoenig
we do not need access levels for these, only for the module displaying them

I have tested this item ✅ successfully on 982aaf6

Great, so now #13857 and I can make the beta1 release :-)

we also need #13838