? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
28 Jan 2017

Pull Request for Issue #13783

Summary of Changes

Filter the possible menu assignment to display only site menu items

Testing Instructions

Create a new admin menu and some menu items.
Edit a site module. Display the Menu Assignment tab.

Before patch, the admin menu is displayed.

screen shot 2017-01-28 at 10 38 23
After patch, it is no more. The patch is similar to #13787

screen shot 2017-01-28 at 10 26 22

@Bakual @izharaazmi

avatar infograf768 infograf768 - open - 28 Jan 2017
avatar infograf768 infograf768 - change - 28 Jan 2017
Status New Pending
avatar infograf768 infograf768 - change - 28 Jan 2017
Title
[admin_menus] Module Menu Assignment should not display custom admin menus
[com_menus] Module Menu Assignment should not display custom admin menus
avatar infograf768 infograf768 - edited - 28 Jan 2017
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2017
Category Administration com_modules
avatar infograf768 infograf768 - change - 28 Jan 2017
Title
[com_menus] Module Menu Assignment should not display custom admin menus
[admin_menus] Module Menu Assignment should not display custom admin menus
avatar infograf768 infograf768 - edited - 28 Jan 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Jan 2017

I have tested this item successfully on 09744bc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13788.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 28 Jan 2017 - Tested successfully
avatar izharaazmi
izharaazmi - comment - 28 Jan 2017

@infograf768 Same as #13787 (comment)

I'd prefer updating the underlying JHtml method to respect now available client_id and then load only the required data. Doing that via layout doesn't sound good to me.

avatar infograf768
infograf768 - comment - 28 Jan 2017

please do

avatar Bakual
Bakual - comment - 28 Jan 2017

Please see #13791. Imho that is a better approach and will fix all instances in one place.

avatar infograf768 infograf768 - change - 28 Jan 2017
The description was changed
Title
[com_menus] Module Menu Assignment should not display custom admin menus
[admin_menus] Module Menu Assignment should not display custom admin menus
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-01-28 21:26:50
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 28 Jan 2017

Add a Comment

Login with GitHub to post a comment