[#13787] - [admin_menus] Custom admin menus should not display as possible Menu Assignment when editing a template style
- Closed
- 28 Jan 2017
- Medium
- Build: staging
- # 13787
- Diff
- infograf768:template_style_menu_assignment
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
New issue
Summary of Changes
Filter the possible menu assignment to display only site menu items
Testing Instructions
Create a new admin menu and some menu items.
Edit a Site template style. Display the Menu Assignment tab.
Before patch, the admin menu is displayed.
After patch, it is no more.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
@infograf768 I'd prefer updating the underlying JHtml method to respect now available client_id and then load only the required data. Doing that via layout doesn't sound good to me.
no opposition to your prposal. please make pr
Unfortunately, the code here doesn't use JHtml. It uses MenusHelper::getMenuLinks(). Which is the method that needs fixing as it is used in many places (also 3rd party).
Should be easy to add a filter for the client there.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-28 21:27:48 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 6efe818
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13787.