[#13776] - [Improvement] Backend menu item edit form : Add Itemid to the alias link value
- Fixed in Code Base
- 28 Jan 2017
- Medium
- Build: staging
- # 13776
- Diff
- marrouchi:staging
User tests: Successful: Unsuccessful:
The link field of an alias menu item displays "index.php?Item=" without the actual item id.
Summary of Changes
I've added the menu item id to the link value in the MenusModelItem::getItem method.
Testing Instructions
Create a menu alias and stay in the menu item edit form.
- Before the PR
After save, you should see "index.php?Itemid=" in the link value readonly field. - After the PR
After save, you should see "index.php?Itemid=XXX" in the link field with XXX being the actual menu item id.
Documentation Changes Required
No documentation changes required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Labels |
Added:
?
|
||
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13776.
RTC please.
@marrouchi it needs another test.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13776.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13776.
Why did you made the PR, the link isn't used IIRC?
@rdeutz I notice this when i've tested the PR #11343 and it seemed to me like a glitch. I find that is more "cleaner" to display the actual Itemid then to display "index.php?Itemid=" in each alias edit form. Sure it's not used anywhere in the code source for now, but it can be helpful for the administrator to know that an alias does not point on any component and it's just simply represented by an Itemid (just like any other menu item link value is shown).
ok it doesn't hurt so I am going to merge it
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-28 10:42:00 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@rdeutz @marrouchi
Except that each save adds the Itemid number in the field.
Look at:
#14264
Why do we need an Id value appended anyway? Menu module handles the item alias itself, I think.
yes, it uses the params aliasoptions to create the link.
I suggest to revert this as it just confuses the user.
Right. However we should re-verify frontend menu afterwards.
I did. No issues after revert as this link field value is just not used at all.
in mod_menu helper
case 'alias':
$item->flink = 'index.php?Itemid=' . $item->params->get('aliasoptions');
break;in /libraries/cms/pathway/site.php
case 'alias':
// If this is an alias use the item id stored in the parameters to make the link.
$url = 'index.php?Itemid=' . $link->params->get('aliasoptions');
break;etc.
Great
Oups, i'm sorry for this. I'll revert right away !
I have tested this item✅ successfully on 64184cc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13776.