[#13775] - Regression 3.7: last template style preview not working #1
- Fixed in Code Base
- 2 Feb 2017
- Medium
- Build: staging
- # 13775
- Diff
- joeforjoomla:staging
User tests: Successful: Unsuccessful:
Reference #13637
Steps to reproduce the issue
Install a new template on Joomla 3.7
Try to open the preview using the URL such as:
http://joomla37/?template=mytemplate
Expected result
The frontend uses the latest installed template named 'mytemplate'
Actual result
The default template is still used
System information (as much as possible)
The code change in site.php included in the function 'getTemplate' caused the regression.
An additional line of code 510 must be added in order to unset the reference to the array before reassigning it:
// Unset the $template reference to the last $templates[n] item cycled in the foreach above to avoid to edit the $templates array in the following assignment
unset($template);
Additional comments
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
It looks like you are reverting changes from several pull requests and moving back to the 3.6.5 state. Please don't do that, only make the changes needed to fix the issue. As I commented on your issue last week that function has had four separate pull requests applied to it when comparing 3.6.5 to current staging.
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-27 21:39:59 |
| Closed_By | ⇒ | joeforjoomla |
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-01-27 21:39:59 | ⇒ | |
| Closed_By | joeforjoomla | ⇒ |
| Status | New | ⇒ | Pending |
Add line 510
// Unset the $template reference to the last $templates[n] item cycled in the foreach above to avoid to edit the $templates array in the following assignment unset($template);
| Category | Libraries | ⇒ |
| Category | ⇒ | Libraries |
OK, I moved the check myself. This PR looks fine to me, tests please.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13775.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13775.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13775.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-02 13:26:49 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
you are modifying parts of this pr #12688 please make sure you do not recreate the issue it solved.