User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript |
Labels |
Added:
?
|
Title |
|
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-25 22:45:17 |
Closed_By | ⇒ | rigin |
@rigin Why have you closed this? As far as I understood you in discussion of #13742 that this one here is needed to make #13742 work.
You yourself asked me to close this branch # 13742. I told you that this file is also needed, but I do not know how to combine revision 2 files in 1 Pull.
This file need to modify , compress and set instead of media/system/js/punycode.js. It provides client-side validation
yes, i did so because i thought that the other thing was just the issue report for this pull request here when i adviced you to close it. but you told me then that it ids another pull request, and so i thought "ok, i was wrong" and assumed you will not close it. Sorry for misunderstanding, was my fault. But you can do following: You can go in github to the branch of this pull request here and then on the website of github edit the javascript file in the same way as you did it in the other, meanwhile closed pull request. Then you have both changes in this one here. I do not have much spare time but if I can I will advice in case of questions. And of course I will test when it is ready and if I have time. Again sorry for misunderstanding and me having confused you.
ahh i see i confuse again!!! I just notice this here is the closed one, and the other one is the open one. So you have to invert my previous comment, add the file not to this but to the other, open pull request.
To this end, I created a Pull # 13770
Testing together
In our country, actively provide such addresses. eg: Вадим.Ригин@почта.рф