? Pending

User tests: Successful: Unsuccessful:

avatar rigin
rigin
24 Jan 2017

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Documentation Changes Required

avatar rigin rigin - open - 24 Jan 2017
avatar rigin rigin - change - 24 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2017
Category JavaScript
avatar rigin rigin - change - 25 Jan 2017
Labels Added: ?
avatar rigin rigin - change - 25 Jan 2017
Title
not only the domain name, the same address of the user can be in UTF-8. In our country, actively provide such addresses. eg: тест@почта.рф
not only the domain name, the same address of the user can be in UTF-8. Part 1
avatar rigin rigin - edited - 25 Jan 2017
avatar rigin
rigin - comment - 25 Jan 2017

In our country, actively provide such addresses. eg: Вадим.Ригин@почта.рф

avatar rigin rigin - change - 25 Jan 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-01-25 22:45:17
Closed_By rigin
avatar rigin rigin - close - 25 Jan 2017
avatar richard67
richard67 - comment - 26 Jan 2017

@rigin Why have you closed this? As far as I understood you in discussion of #13742 that this one here is needed to make #13742 work.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13741.

avatar rigin
rigin - comment - 26 Jan 2017

You yourself asked me to close this branch # 13742. I told you that this file is also needed, but I do not know how to combine revision 2 files in 1 Pull.

This file need to modify , compress and set instead of media/system/js/punycode.js. It provides client-side validation

avatar richard67
richard67 - comment - 26 Jan 2017

yes, i did so because i thought that the other thing was just the issue report for this pull request here when i adviced you to close it. but you told me then that it ids another pull request, and so i thought "ok, i was wrong" and assumed you will not close it. Sorry for misunderstanding, was my fault. But you can do following: You can go in github to the branch of this pull request here and then on the website of github edit the javascript file in the same way as you did it in the other, meanwhile closed pull request. Then you have both changes in this one here. I do not have much spare time but if I can I will advice in case of questions. And of course I will test when it is ready and if I have time. Again sorry for misunderstanding and me having confused you.

avatar richard67
richard67 - comment - 26 Jan 2017

ahh i see i confuse again!!! I just notice this here is the closed one, and the other one is the open one. So you have to invert my previous comment, add the file not to this but to the other, open pull request.

avatar rigin
rigin - comment - 26 Jan 2017

To this end, I created a Pull # 13770

avatar rigin
rigin - comment - 26 Jan 2017

Testing together

Add a Comment

Login with GitHub to post a comment