? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
23 Jan 2017

Pull Request for Issue #13699 .

Summary of Changes

Adds a new parameter to the news module which allows to enable/disable the triggering of the additional plugin events onContentAfterTitle, onContentBeforeDisplay and onContentAfterDisplay.

Testing Instructions

  • Add some custom fieldsa to articles
  • Create and publish a news module
  • See that the custom fields appear
  • Set the new parameter "Trigger Plugin Events" to "No" and verify that the fields no longer appear.

Notes

Please have a look over the language strings. I'm not sure if they are correct (eg can the voting be shown there as well? The plugin event suggests so.) and proper english.

Documentation Changes Required

None

avatar Bakual Bakual - open - 23 Jan 2017
avatar Bakual Bakual - change - 23 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jan 2017
Category Language & Strings Modules Front End
avatar zero-24
zero-24 - comment - 23 Jan 2017

Adds a new parameter to the news module which allows to enable/disable the triggering of the additional plugin events onContentAfterTitle, onContentBeforeDisplay and onContentAfterDisplay.

Why do you want to add a option for that why not enabled this by default? Maybe we should not use com_content.aricle as context maybe better mod_articles_news?

avatar Bakual
Bakual - comment - 23 Jan 2017

Why do you want to add a option for that why not enabled this by default?

It's enabled by default since that is the current behavior. The idea is to allow to disable it ?
If you change the context, it means fields wouldn't work at all anymore and all other content plugins would have to adjust as well. com_content.article is the correct context since we're passing an article from com_content.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Jan 2017

I have tested this item successfully on 1516e37

"Trigger Plugin Events" set to "No"/"Yes" show or hide Fields of Article.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13703.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 23 Jan 2017 - Tested successfully
avatar coolcat-creations
coolcat-creations - comment - 24 Jan 2017

Is it regarding custom fields or all plugin events? It should just disable custom_fields by default... what if i want to display plugins but not the fields?

avatar mbabker
mbabker - comment - 24 Jan 2017

Without creating a separate event dispatcher with only the listeners you want responding to an event, you can't say "I want this place to trigger onContentPrepare but only use the email cloaking and loadmodule plugins" (as an example). So it's an all or nothing thing, that's just how event dispatchers work.

avatar Bakual
Bakual - comment - 24 Jan 2017

If you only want to show other plugins but not fields, you need to set the field to not display automatic and include it manually in an override if needed. That's why that option exists.

avatar laoneo
laoneo - comment - 26 Jan 2017

I have tested this item successfully on 1516e37


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13703.

avatar laoneo laoneo - test_item - 26 Jan 2017 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 26 Jan 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 26 Jan 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13703.

avatar rdeutz rdeutz - change - 27 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-27 18:25:07
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 27 Jan 2017
avatar rdeutz rdeutz - merge - 27 Jan 2017

Add a Comment

Login with GitHub to post a comment