User tests: Successful: Unsuccessful:
Pull Request for Issue #13699 .
Adds a new parameter to the news module which allows to enable/disable the triggering of the additional plugin events onContentAfterTitle, onContentBeforeDisplay and onContentAfterDisplay.
Please have a look over the language strings. I'm not sure if they are correct (eg can the voting be shown there as well? The plugin event suggests so.) and proper english.
None
Status | New | ⇒ | Pending |
Category | ⇒ | Language & Strings Modules Front End |
Why do you want to add a option for that why not enabled this by default?
It's enabled by default since that is the current behavior. The idea is to allow to disable it
If you change the context, it means fields wouldn't work at all anymore and all other content plugins would have to adjust as well. com_content.article
is the correct context since we're passing an article from com_content.
I have tested this item
"Trigger Plugin Events" set to "No"/"Yes" show or hide Fields of Article.
Is it regarding custom fields or all plugin events? It should just disable custom_fields by default... what if i want to display plugins but not the fields?
Without creating a separate event dispatcher with only the listeners you want responding to an event, you can't say "I want this place to trigger onContentPrepare
but only use the email cloaking and loadmodule plugins" (as an example). So it's an all or nothing thing, that's just how event dispatchers work.
If you only want to show other plugins but not fields, you need to set the field to not display automatic and include it manually in an override if needed. That's why that option exists.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-27 18:25:07 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
Why do you want to add a option for that why not enabled this by default? Maybe we should not use
com_content.aricle
as context maybe bettermod_articles_news
?