[#13702] - [com_fields] Removes the ID attribute from the field when it is shown as part of an item
- Fixed in Code Base
- 26 Feb 2017
- Medium
- Build: staging
- # 13702
- Diff
- Bakual:DontUseFieldIdInFrontend
User tests: Successful: Unsuccessful:
Currently, when a field is shown as part of an item (not in a form!), it has an ID attribute following the scheme "field-entry-ID". That means if multiple items (eg articles) are present on a page and all have that field set, you get an invalid HTML markup since IDs have to unique.
Summary of Changes
Removing the ID since it's not needed anyway.
Testing Instructions
- Create fields and put values in it in at least two articles
- Create and publish the "Articles - Newsflashmodule"
- Check frontend and see that the field appears in multiple locations. Check the source code and see the id attribute present before this PR and gone after it.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_fields |
I have a suggestion, it may be interesting to add the item alias as a class for CSS styling purposes
You can already set a "render class" for the field. I don't think it makes sense to add yet another parameter to it.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13702.
I would like to have an id, but it's probably rather hard to create an id here which will be unique even when two times the same event is triggered.
I would like to have an id, but it's probably rather hard to create an id here which will be unique even when two times the same event is triggered.
It's a bad idea to use IDs in frontend because of this reasons. That's why we usually don't generate any IDs at all except in forms. Everything else may be on the site more than once. You can use classes instead.
Will do the contact one later today, good catch!
ok.
Actually, I already did it in this PR. Or did I miss something?
True
I guess this one can be set to RTC?
| Labels |
Added:
?
|
||
Rebased and fixed conflict.
RTC or retest?
Re-Test please
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13702.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-26 22:38:49 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on baab0b0
Test was successful !
I have a suggestion, it may be interesting to add the item alias as a class for CSS styling purposes (eg class="class="field-entry field-entry-").
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13702.