[#13649] - Admin menu: batch process move to submenu impossible [FIX]
- Fixed in Code Base
- 3 Feb 2017
- Medium
- Build: staging
- # 13649
- Diff
- izharaazmi:am-batch
- Success continuous-integration/drone the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #13632.
Summary of Changes
Show menu and menu items for batch target for batch operation based on relevant client id only.
Testing Instructions
Perform batch operations move/copy on backend custom menu items and front-end menu items. Both should work. Frontend menu items should not show when working with backend menu items and vice versa.
Documentation Changes Required
None
| Milestone |
Added: |
||
I have successfully tested this PR. I just can't seem to convince the Joomla Issue Tracker to let me register a successful test...
I was able to move several items at once between different menu levels (top level and first sub-menu level).
I can also confirm that I now only see the administrator menus when I'm trying to move administrator menu items.
@nikosdion
see discussion here
#13739 (comment)
and following, which, once implemented as new PR, shall solve the main UI issue.
@infograf768 This one is a different case and not related to the other discussion. Batch move/copy etc issue raised by @nikosdion #13632 is being fixed here. So we can accept his test result here.
About the other discussion, I'll work on it.
mbabker
- 
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Libraries Unit Tests |
| Labels |
Added:
?
|
||
| Category | Administration com_menus Libraries Unit Tests | ⇒ | Administration com_menus Libraries |
@rdeutz @infograf768 Looks like we missed this one.
@izharaazmi
Will look at it today. I also have some other stuff to look at.
@izharaazmi
Batch process of admin menus should not propose language as well as access, which can't be set anyway for these menu items.
As I noted here:
#13884
these can be added in 4.0 if someone find a correct way to use these in the admin UI (out of scope imho for the 3.x series.
For now, access can be defined by the menu module itself:
Example: One can create an Access Level of type AdminFrench and define that access level for a specific custom User group which uses French language in back-end.
It is rather easy to implement by just checking client id.
| Labels |
Removed:
?
|
||
| Category | Administration com_menus Libraries | ⇒ | Administration com_menus Language & Strings Libraries |
Filter by trashed and client id = 1 was another thing of concern. Updated.
:)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13649.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13649.
| Status | New | ⇒ | Ready to Commit |
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13649.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-03 10:40:25 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
Removed: ? |
||
@izharaazmi it looks like there are unit test fails? Can you take a look? https://travis-ci.org/joomla/joomla-cms/jobs/193448159