Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13578] - Merge list field options using Registry->merge

? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
12 Jan 2017

Pull Request for Issue #13558.

Summary of Changes

Currently, list field options defined in the field are added to the ones defined in the plugin.
After this PR they are merged using Registry->merge() where parameters defined in the field overwrite the ones defined in the plugin.

Testing Instructions

See in issue for some pics

  • Create some options in the list/checkboxes/radio plugin.
  • Create the respective fields and define some options in them.
  • See what options will be available when you edit the item (eg the article).
    Before this PR, you should see all options you defined, both from plugin and field. After this PR you will only see the ones from the field. The plugin ones are only shown if none are defined in the field.

Documentation Changes Required

None

avatar Bakual Bakual - open - 12 Jan 2017
avatar Bakual Bakual - change - 12 Jan 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jan 2017
Category ⇒ Front End Plugins
avatar Bakual Bakual - change - 12 Jan 2017
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Jan 2017

I have tested this item ✅ successfully on 6b412df

Works as written in Instructions.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13578.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 15 Jan 2017 - Tested successfully
avatar zero-24
zero-24 - comment - 16 Jan 2017

@Bakual there are conflicts now ;)

avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2017
Category Front End Plugins ⇒ Administration com_fields Front End Plugins
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2017
Category Front End Plugins Administration com_fields ⇒ Administration com_fields
avatar Bakual
Bakual - comment - 16 Jan 2017

Rebased and conflicts solved.

avatar webnet-assmann
webnet-assmann - comment - 5 Feb 2017

I have tested this item ✅ successfully on 627422d

test was successfull

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13578.

avatar webnet-assmann webnet-assmann - test_item - 5 Feb 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Feb 2017

I have tested this item ✅ successfully on 627422d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13578.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 5 Feb 2017 - Tested successfully
avatar zero-24 zero-24 - change - 5 Feb 2017
Milestone Added:
Status Pending ⇒ Ready to Commit
Labels Added: ?
avatar wilsonge wilsonge - change - 5 Feb 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-02-05 22:22:05
Closed_By ⇒ wilsonge
Labels
avatar wilsonge wilsonge - close - 5 Feb 2017
avatar wilsonge wilsonge - merge - 5 Feb 2017

Add a Comment

Login with GitHub to post a comment