[#13574] - Fix issue where fields is false
- Fixed in Code Base
- 15 Jan 2017
- Medium
- Build: staging
- # 13574
- Diff
- wilsonge:fields-sql-issue
User tests: Successful: Unsuccessful:
Summary of Changes
When there is an SQL issue getting the fields (maybe you update from a version before fields to after fields without triggering the sql update etc), then then JModelList::getItems will return false https://github.com/joomla/joomla-cms/blob/staging/libraries/legacy/model/list.php#L190 and you subsequently get PHP errors trying to do a foreach on false.
Warning: Invalid argument supplied for foreach() in JROOT/administrator/components/com_fields/helpers/fields.php on line 146
Do we want to display a warning in the frontend about such issues? Only show something for super admins? Obviously in the case of the table not existing then you'll get warnings shown in the backend.
Testing Instructions
Delete the #__fields table. Before the patch you get 4 php warnings on an article. After patch no warning
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
I have tested this item
View Article on Frontend shows no more Warning after Patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13574.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks guys!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13574.
Bakual
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-15 19:46:12 |
| Closed_By | ⇒ | Bakual | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 845b556
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13574.