[#13573] - It's 2017. Happy New Year
- Fixed in Code Base
- 12 Jan 2017
- Medium
- Build: staging
- # 13573
- Diff
- wilsonge:copyright
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Administration com_admin SQL Postgresql |
jeckodevelopment
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-12 12:26:23 |
| Closed_By | ⇒ | jeckodevelopment | |
| Labels |
Added:
?
|
||
@andrepereiradasilva you should have mentioned that a bit earlier, now almost all the PRs are out of sync...
now almost all the PRs are out of sync...
Changing the file header doesn't make PRs out of sync unless said PR is changing the file header. Same comment every year
I forgot about bump. My bad!
@jeckodevelopment @wilsonge please add the milestone on merge ;)
I kinda deliberately didn't - this is just junk in the changelog? I dunno.....
Not every pull request needs to go to a milestone. Some changes are administrative in nature and really don't matter. If someone ran a PR updating the version numbers based on running build/bump.php does that really need to be there?
In the past we added every change even just in the tests or build folder to a milestone. If we want to change that just tell me how exactly you want to handle that. So which change need a milestone one which not.
I am pushing admin changes directly without making a PR, so the junk started as the PR was made. Any PR should have a milestone, test, ....
actually bump.php would do this automatticly? on next run
https://github.com/joomla/joomla-cms/blob/staging/build/bump.php#L307