? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
11 Jan 2017

fixes #12598 @TorstenE to provide further details for testing

Pull Request for Issue #12598 .

Summary of Changes

Remove Whitespace within link a tag to prevent line wrapping

avatar PhilETaylor PhilETaylor - open - 11 Jan 2017
avatar PhilETaylor PhilETaylor - change - 11 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jan 2017
Category Modules Front End
avatar n9iels
n9iels - comment - 13 Jan 2017

Hi @PhilETaylor,

Thanks for your contribution! I placed a comment on your changes. Can you please do the same for these lines:
https://github.com/PhilETaylor/joomla-cms/blob/a54e1e724385b65e9ae5d40a707f72df4e779dc7/modules/mod_articles_category/tmpl/default.php#L22-L24

avatar PhilETaylor
PhilETaylor - comment - 13 Jan 2017

If the use of this function is going to be standardized in the CMS, it should be done as a separate PR. This is fine as is.

So I'll not make any further changes to this PR then.

Lets hope @TorstenE comes back and tests if it fixes his issue,

avatar sanderpotjer
sanderpotjer - comment - 15 Jan 2017

I have tested this item successfully on a54e1e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13561.

avatar sanderpotjer sanderpotjer - test_item - 15 Jan 2017 - Tested successfully
avatar marrouchi
marrouchi - comment - 26 Jan 2017

Unable to reproduce the issue ... :(

avatar PhilETaylor
PhilETaylor - comment - 5 May 2017

Paging... @TorstenE Please come back and test if this fixes your issue,

avatar Quy
Quy - comment - 7 May 2017

@TorstenE has not been active on GitHub since reporting this issue. I doubt that you will hear from him soon. I am wondering if this is a CSS issue on his end.

avatar TorstenE
TorstenE - comment - 8 May 2017

I had it changed in my own files myself. Yes, it works wonderfully - thank you

avatar PhilETaylor
PhilETaylor - comment - 8 May 2017

Excellent - this has had two good tests, please RTC (maybe @franz-wohlkoenig can update the test of @TorstenE on issues.joomla.org to reflect the successful test.

@Quy I am wondering if this is a CSS issue on his end.

Nope, a known html issue that can cause issues

avatar TorstenE
TorstenE - comment - 9 May 2017

I have tested this item successfully on a54e1e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13561.

avatar TorstenE TorstenE - test_item - 9 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 May 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 9 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-09 18:40:22
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 9 May 2017
avatar rdeutz rdeutz - merge - 9 May 2017

Add a Comment

Login with GitHub to post a comment