[#13560] - Remove Isis Bootstrap grid override
- Fixed in Code Base
- 14 Jan 2017
- Medium
- Build: staging
- # 13560
- Diff
- ciar4n:bs-grid
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR removes the following, fixing a multi column margin issue where all fluid bootstrap columns (excluding first column) shift to the left on most screen sizes..
.row-fluid [class*="span"] {
margin-left: 15px;
}
I can't imagine the original purpose for this CSS, regardless it is incorrect as row-fluid span margins should be in %. Issue becomes more noticeable the larger the screen size. Removing the CSS reverts back to the bootstrap default.
Testing Instructions
Apply patch and check Control Panel or any view with bootstrap columns.
Before Patch
After Patch
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I have tested this item
SORRY!! Following statement is WRONG!! So, my unsuccessfull test is not correct!!
This is a basic Bootstrap 2 rule (call it "core rule" if you want to). Changing/Removing it is a killer for the whole BS 2 grid system.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13560.
This is a basic Bootstrap 2 rule (call it "core rule" if you want to). Changing/Removing it is a killer for the whole BS 2 grid system.
If you were referring to something in https://github.com/twbs/bootstrap/blob/v2.3.2/docs/assets/css/bootstrap.css#L407-L421 I'd agree. But this is an Isis template specific override and it is indeed incorrect. There are a lot of bad CSS overrides of the core Bootstrap elements in Joomla (especially the RTL files), those need to be corrected.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13560.
@mbabker I see what you mean. It all seems a bit of a minefield. Excluding the Isis overrides, some of the Bootstrap responsive fluid percentages (margin-left vs width) don't seem to add up correctly which would indicate issues in the /media/jui folder. Effects the BS grid on most modal iframes leaving no easy fix for the likes of #13489. Presuming I'm correct this may explain the original intent of some of these dodgy Isis overrides.
The LESS files are fine in media/jui. It's the lessc compiler that's screwing it up massively. For the joomla.org site template I stopped using it and changed to the recess compiler the Bootstrap team was using at 2.3.2. We're using media/jui LESS and some custom CSS to flatten things out and implement some of our custom stuff. Take a look at https://www.joomla.org/templates/joomla/css/template.css for the results.
The PHP compiler isn't reliable but in 2012 the project wouldn't accept a "need to be able to run npm install" requirement for contributing UI related fixes and I don't think the subject's ever been revisited. I just know I won't use lessc or the extending JLess class for any reason personally because that library is too problematic.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13560.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13560.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-14 19:57:19 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
I have tested this item✅ successfully on fffdce4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13560.