[#13554] - [com_fields] Inherit url scheme restriction from fields plugin
- Fixed in Code Base
- 18 Jan 2017
- Medium
- Build: staging
- # 13554
- Diff
- Digital-Peak:url-scheme
User tests: Successful: Unsuccessful:
Pull Request for comment #13319 (comment).
Summary of Changes
Checks if the parameter is NULL and then fetches the parameter from the plugin. Additionally the default scheme value is removed to allow any scheme initially.
Testing Instructions
- In the Fields -> Url Plugin, the scheme should be set to HTTPS.
- Create an url field and leave the scheme empty.
Expected result
When editing an article, only urls with the scheme https should be allowed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Front End Plugins |
| Labels |
Added:
?
|
||
I'v added another commit which should fix the inheritance issue.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13554.
I have tested this item
Test OK
.... the only observation is that there is no validation message about what field or why it is invalid.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13554.
Conflicts resolved
@jeckodevelopment can you set this to RTC please as we have two tests.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13554.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-18 14:22:50 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item? unsuccessfully on 3a564e6
That doesn't seem to work yet.
When I set the schemes to "https" in the field, I get an error when I enter "http://www.joomla.org"
When I leave the schemes in the field empty and only set it in the plugin to "https", the article saves without any error.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13554.