[#13553] - System info fatal error on symbolic linked folders
- Fixed in Code Base
- 30 Jun 2019
- Medium
- Build: staging
- # 13553
- Diff
- n3t:staging
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #13552.
Summary of Changes
isDot check first, before isDir
Testing Instructions
Follow the Issue tracker https://issues.joomla.org/tracker/joomla-cms/13552
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
| Labels |
Added:
?
|
||
| Category | Administration com_admin | ⇒ | Administration com_admin com_modules Language & Strings |
| Labels |
Added:
?
|
||
| Category | Administration com_admin com_modules Language & Strings | ⇒ | Administration com_modules Language & Strings |
:-/ yeah, I am not so much familier with github, bit lost now...
| Category | Administration com_modules Language & Strings | ⇒ | Administration com_admin |
Ok, now it should be as before, sorry for complications...
@franz-wohlkoenig no this should be still a valid fix for the issue.
@franz-wohlkoenig even commits are bit masched up, it still solves the initial issue, and the PR is back in its initial state.
I have tested this item
open basedir message disappears after applying patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13553.
| Status | Pending | ⇒ | Confirmed |
| Status | Confirmed | ⇒ | Discussion |
I couldn't reproduce the issue on Linux-4.17.8-1 with PHP7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13553.
I have tested this item
I followed the instructions step by step but i coundn't reproduce the issue. I think it can be close.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13553.
IMO negative tests were not carried out with full understanding of the problem.
Example.
Php has access to /var/images, then we want to list directory like
$folder = new DirectoryIterator(JPATH_ROOT . '/images'); // In real, it will be `/var/images`and now we have a list of elements:
.
..
image1.png
image2.pngwhen we are in line .., php want to get access to /var/images/.. which is /var and then we get the error because php has access only to /var/images not /var.
This PR is valid. I did code review.
@csthomas Thank you for your input. @Schmidie64 @niklas-deworetzki-thm Please review your testing and check again.
@csthomas oh, now I see the problem here. I'm sorry, I misunderstood at first, that he had problems with accessing the symlinked directory.
But as far as I understand now, the problem is not the symlink. PHP tries to check isDir on .. . This folder is not in baseDir. So PHP fails and shows an error. And this error is 1. unnecessary and 2. shows critical information about the system path to the user.
I'm testing it now, knowing the real issue. Thank you for clarifying it.
I have tested this item
Tested this
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13553.
@henkrijneveld can you please retest?
@Schmidie64 Can you please test this again?
| Status | Discussion | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-30 23:30:51 |
| Closed_By | ⇒ | HLeithner |
@n3t it looks like you committed to the wrong branch?