[#13518] - Change email notification to use site from address (Fix #9261)
- Fixed in Code Base
- 26 May 2017
- Medium
- Build: staging
- # 13518
- Diff
- mbabker:fix-9261
User tests: Successful: Unsuccessful:
Pull Request for Issue #9261
Summary of Changes
The email notification sent when sending a private message uses the "from" user's email address as the sender which can cause some sending failures (see referenced issue for examples). This changes the process to set the "from" user as the reply-to address instead.
As well, proper error checks will be made when setting the reply-to and recipient addresses and the message will not be sent if this step fails. Additionally, a message will be displayed if sending
Concurrent with #13504 the log statements are wrapped in try/catch.
Testing Instructions
Pre-patch, an email message sent via the "Private Message" feature of com_messages will have the "from" address set as the sending user. Post-patch, the message will use the site's configured from address with the sending user set as the reply-to address.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_messages Language & Strings |
As pointed out in #16107 the site email address is not a required or a validated field
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13518.
Still a better option than potentially spoofing someone's email address as if it's configured properly that would be valid data from the site owner.
Somewhat related: Our forms were setup to use the user's email for the FROM, and got bounced/rejected:
550 5.1.0 ###.###.###.### is not allowed to send from <example.com> per it's SPF Record. Please inspect your SPF settings, and try again. IB508 http://x.co/srbounce
Now FROM is the site's email and Reply-to is the user's email.
Why do need to include REPLY-TO? The email notification is generic. There is no context to the message to know what to reply to.
Subject: A new private message has arrived from Acme Corp
Message: Please log in to http://www.example.com/administrator/index.php?option=com_messages&view=message&message_id=2 to read your message.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13518.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-26 17:52:30 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on db2e207
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13518.