[#13517] - Normalize finder tables across 3 db systems and add default values
- Closed
- 23 May 2018
- Medium
- Build: staging
- # 13517
- Diff
- andrepereiradasilva:issue-13509
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #13509 (part) and probably other issues relating finder tables in more strict db systems (which in joomla 4.0 mysql will be also).
Summary of Changes
Normalize the #__finder_* table across db systems.
Only tested in mysql.
@waader please check mssql
@alikon please also check postgresql and mssql.
Testing Instructions
- SQL code review
- Test update: Apply patch, manually run the sql query for your Db system, confirm db table, confirm all fine
- Test install: apply patch, delete configuration.php do a normal install, confirm db table, confirm all fine
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
| Category | ⇒ | SQL Administration com_admin Postgresql MS SQL Installation |
| Labels |
Added:
?
|
||
don't know the best query in mssql
if you confirm me that ALTER TABLE [#__finder_filters] ADD DEFAULT '' FOR [title]; work on mssql i can change.
But there are also cases like removing NULL, setting NOT NULLand adding DEFAULT '' in the same field.
See https://github.com/joomla/joomla-cms/pull/13517/files#diff-1afe140cec5b5f3c972a51ee6b46e110R2093
@andrepereiradasilva Are you available to fix conflict/rebase all and change mssql file?
mssql sql file should be change as @waader say.
Take a look at #14102
About *weight: Current mysql uses 0 as DEFAULT implicitly.
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Milestone |
Removed: |
||
Thank you for these optimisations. Considering that there has been no response by @andrepereiradasilva, I will try to create a new PR from this. I also noticed that the language columns are not unified with the rest of the language columns of Joomla. I would aim that new PR against the 4.0-dev branch. Can I be assigned to this issue, so that I don't forget?
@Hackwar thanks - @andrepereiradasilva is no longer available and that is why this pr is flagged "needs a new owner"
Quy
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-23 21:19:54 |
| Closed_By | ⇒ | Quy |
| Closed_Date | 2018-05-23 21:19:54 | ⇒ | 2018-05-23 21:19:55 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/13517
Should the alter statements for mssql no be formed like in 3.1.0.sql so we would have for example
ALTER TABLE [#__finder_filters] ADD DEFAULT ('') FOR [title];
instead of
ALTER TABLE
#__finder_filtersMODIFYtitlevarchar(255) NOT NULL DEFAULT '';