? ? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
8 Jan 2017

Pull Request for Issue #13508 (use issue part).

Summary of Changes

Fix for #13508 (use issue part)

Testing Instructions

  1. apply patch
  2. Install a language in mssql. no use error. note you will get another error, but the use error is fixxed here

Documentation Changes Required

None

avatar andrepereiradasilva andrepereiradasilva - open - 8 Jan 2017
avatar andrepereiradasilva andrepereiradasilva - change - 8 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jan 2017
Category Administration com_installer
avatar waader
waader - comment - 8 Jan 2017

The semicolon in line 66 should be deleted. After that I get:
Fatal error: Using $this when not in object context in joomla37\administrator\components\com_installer\models\languages.php on line 151

avatar andrepereiradasilva andrepereiradasilva - change - 8 Jan 2017
Labels Added: ?
65f086a 8 Jan 2017 avatar andrepereiradasilva ups
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Jan 2017

semicolon deleted, thanks
that fatal error doesn't seem related to this mssql issue this PR solves.
Please open a new issue for that

avatar zero-24
zero-24 - comment - 8 Jan 2017

@waader

The semicolon in line 65 should be deleted. After that I get:
Fatal error: Using $this when not in object context in joomla37\administrator\components\com_installer\models\languages.php on line 151

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/models/languages.php#L151

Can you try staging? at this line we have no $this in staging ?

avatar waader
waader - comment - 8 Jan 2017

With your patch applied it "becomes" line 151.

avatar alikon
alikon - comment - 9 Jan 2017

I have tested this item successfully on 65f086a

solve [Microsoft][SQL Server Native Client 11.0][SQL Server]Incorrect syntax near the keyword 'use'.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13512.
avatar alikon alikon - test_item - 9 Jan 2017 - Tested successfully
avatar waader
waader - comment - 10 Jan 2017

@alikon Did you do a code review? I keep getting the mentioned syntax error after applying the patch. I tried with latest staging, no data installed.

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Jan 2017

@waader the thing is that seems a different error. another one. this PR only solves the use part.

avatar waader
waader - comment - 10 Jan 2017

I have tested this item successfully on 65f086a

Ok, thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13512.

avatar waader waader - test_item - 10 Jan 2017 - Tested successfully
avatar andrepereiradasilva andrepereiradasilva - change - 10 Jan 2017
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 10 Jan 2017
avatar andrepereiradasilva andrepereiradasilva - change - 10 Jan 2017
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 10 Jan 2017
avatar andrepereiradasilva andrepereiradasilva - change - 10 Jan 2017
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 10 Jan 2017
avatar jeckodevelopment jeckodevelopment - change - 10 Jan 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 10 Jan 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13512.

avatar rdeutz rdeutz - close - 10 Jan 2017
avatar rdeutz rdeutz - merge - 10 Jan 2017
avatar rdeutz rdeutz - change - 10 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-10 17:28:19
Closed_By rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment