Indexing with mssql is currently broken.

When applying your patch I get:
[Microsoft][SQL Server Native Client 11.0][SQL Server]Cannot insert the value NULL into column 'term_id', table 'joomla35.dbo.#__finder_tokens_aggregate'; column does not allow nulls. INSERT fails.

@waader i think that is the same issue as #13509

@waader thanks for testing! It shouldn't have to do anything with this patch, and I assume it is what @andrepereiradasilva commented. Just to be sure, does it work without the patch?

It has nothing to do with your patch but this is untestable at the moment with mssql. Adding a default value for term_id does not the trick as it is the key value.

@mbabker OK, got it, thanks.

Conflicts resolved. Pls check and merge.

Code review and test please. Thank you

Note: as stated in @waader 's #13511 (comment), MSSQL is untestable at the moment.

Conflicts resolved. Please test

@andrepereiradasilva & @Quy
Could you review and test this one?

this one i'm not confartable to review it all. i can review only what i can so will not consider tested.

No problem, I know it's a complex one.

the part that i reviewed seems fine now

@andrepereiradasilva Travis didn't like the quoteName(array), I think. Will check

at least in select you can use it. see https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_banners/models/tracks.php#L99
probably an explode in needed in the columns case, maybe not worth it sorry. if not sorry

this one i'm not confartable to review it all. i can review only what i can so will not consider tested.

Same here

CI tests are passing now. Testers welcome! ;)
Thanks @andrepereiradasilva and @Quy for reviewing and suggestions.

There are some performance improvements in regards to indexing in this PR.
However, it needs testing to get to RTC. Anyone?

@mbabker Any chance this can get into 3.8? I don't see this getting into 3.7 and no one wants to test it ?
This would then allow #12253 to finally get in as well...

On a read seems fine. It'd be good if someone would actually help with testing (install Joomla with testing sample data, install patch, and run Smart Search indexer; pretty simple).

Yes, but no one wants to do it...
BTW, Fixed the CS that you pointed out

if Test is 3.8-dev + Sample Data + run Smart Search-Index on MySQLi i will test.

@frankmayer Test Instructions wasn't clear for me.

I have tested this item ✅ successfully on 5b5376e

System information

3.8-dev
Multilanguage Site
macOS Sierra, 10.12.5
Firefox 54 (64-bit)

MAMP 4.1.1

• PHP 7.0.15
• MySQLi 5.6.35

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13511.}

Thank you @franz-wohlkoenig for giving it a shot ?

@mbabker Is @franz-wohlkoenig 's test enough for you to merge? Should I move this PR against the 3.8 branch?
Also, should I move the other one (#12253) to the 3.8 branch?

Also, should I move the other one (#12253) to the 3.8 branch?

No, trying to phase out that branch now that it's merged to staging.

@zero-24 This one is merged, I think you wanted to add #12253 to the Joomla 3.8.0 milestone ? ;)

@frankmayer i don't get your point? Everything that is merged should have a milestone. That is the reason i added the 3.8.0 one. The other PR is not merged yet nor did somone took the final release decision on that so this have no milestone yet ?

Oh, I see. Sorry, my bad. I was under the impression that milestones were only set prior to merging. Didn't know that you also set them afterwards. ?

It allows you to track all the changes / PRs included per release x ;)

Ah, thanks, nice to learn new things :)