? ? Pending

User tests: Successful: Unsuccessful:

avatar frankmayer
frankmayer
5 Jan 2017

Summary of Changes

[Indexer] Replace StringHelper::trim() calls with simple trim() when only ASCII characters are to be trimmed. Saves a few cycles and time when indexing.

Testing Instructions

Code review only. Should not change behavior.

Documentation Changes Required

No.

avatar frankmayer frankmayer - open - 5 Jan 2017
avatar frankmayer frankmayer - change - 5 Jan 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jan 2017
Category Administration com_finder
avatar anibalsanchez
anibalsanchez - comment - 5 Jan 2017

I have tested this item successfully on 397cd09

Indexer OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13478.

avatar anibalsanchez anibalsanchez - test_item - 5 Jan 2017 - Tested successfully
avatar zero-24
zero-24 - comment - 4 Feb 2017

I have tested this item successfully on 397cd09


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13478.

avatar zero-24 zero-24 - change - 4 Feb 2017
Milestone Added:
Status Pending Ready to Commit
Labels Added: ? ?
avatar zero-24
zero-24 - comment - 4 Feb 2017

RTC thanks #jc17de


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13478.

avatar zero-24 zero-24 - test_item - 4 Feb 2017 - Tested successfully
avatar rdeutz rdeutz - change - 4 Feb 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-04 21:44:46
Closed_By rdeutz
Labels
avatar rdeutz rdeutz - close - 4 Feb 2017
avatar rdeutz rdeutz - merge - 4 Feb 2017

Add a Comment

Login with GitHub to post a comment