Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13456] - [com_fields] Hide tab when empty

? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
3 Jan 2017

Pull Request for Issue #13395.

Summary of Changes

When a field will be shown on the front end, then an empty tab is shown on the back end.

Testing Instructions

  • Create a new article custom field and set the option "Show On" to front end
    image
  • Open an article in the back end.

Expected result

Tab with name fields is not shown.

Actual result

Empty tab with the name Fields is shown.

avatar laoneo laoneo - open - 3 Jan 2017
avatar laoneo laoneo - change - 3 Jan 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2017
Category ⇒ Administration com_fields
avatar cpfeifer
cpfeifer - comment - 3 Jan 2017

I'm getting this on the field pages:
Fatal error: Class 'FieldsHelperInternal' not found in administrator/components/com_fields/views/fields/view.html.php on line 95

avatar zero-24
zero-24 - comment - 3 Jan 2017

That helper got moved we need to update that PR against staging / to the new name ;)

avatar zero-24
zero-24 - comment - 3 Jan 2017

See #13316

avatar laoneo
laoneo - comment - 4 Jan 2017

I guess @cpfeifer needs to update his Joomla installation to the latest staging.

avatar laoneo laoneo - change - 4 Jan 2017
Labels Added: ?
avatar cpfeifer
cpfeifer - comment - 4 Jan 2017

I have tested this item ✅ successfully on 60443b4

Tested in Articles, Contacts and Users and it looks good :)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13456.

avatar cpfeifer cpfeifer - test_item - 4 Jan 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Jan 2017

I have tested this item ? unsuccessfully on 60443b4

Joomla! 3.7.0-alpha1: Tab ist hidden, but in "Fields" and "Field Groups" in Article get Error:
bildschirmfoto 2017-01-04 um 19 43 56

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13456.
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 4 Jan 2017 - Tested unsuccessfully
avatar zero-24
zero-24 - comment - 4 Jan 2017

@franz-wohlkoenig

You need to update to the last staging or nightly ;)

avatar anibalsanchez
anibalsanchez - comment - 4 Jan 2017

I have tested this item ✅ successfully on 60443b4

Test OK

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13456.

avatar anibalsanchez anibalsanchez - test_item - 4 Jan 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Jan 2017

@zero-24 is ther a common way to get staging or nightly (you mean Update Channel "Custom Url")?

avatar zero-24
zero-24 - comment - 5 Jan 2017

You can use this: https://developer.joomla.org/nightly-builds.html but only for testing!

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Jan 2017

I have tested this item ✅ successfully on 60443b4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13456.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 5 Jan 2017 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 5 Jan 2017
Status Pending ⇒ Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 5 Jan 2017

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13456.

avatar rdeutz rdeutz - change - 6 Jan 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-01-06 08:07:29
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 6 Jan 2017
avatar rdeutz rdeutz - merge - 6 Jan 2017

Add a Comment

Login with GitHub to post a comment