[#13455] - Proper escaping for various JS strings
- Fixed in Code Base
- 4 Jan 2017
- Medium
- Build: staging
- # 13455
- Diff
- infograf768:js_strings
User tests: Successful: Unsuccessful:
This PR to complete #13425 in various places where JS language strings are incorrect.
#13425 deals only with toolbar buttons.
Summary of Changes
Files modified:
/plugins/installer/folderinstaller/tmpl/default.php
/plugins/installer/packageinstaller/tmpl/default.php
/components/com_mailto/views/mailto/tmpl/default.php
/administrator/templates/hathor/html/com_contenthistory/history/modal.php
/administrator/components/com_contenthistory/views/history/tmpl/modal.php
I did not touch at fof
strapper, joomla.php
Let me know if this should be added.
Testing Instructions
On a staging create 2 en-GB.override.ini
For back-end:
JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST="Please first make a "_QQ_"selection"_QQ_" \"from\" the list."
PLG_INSTALLER_PACKAGEINSTALLER_NO_PACKAGE="Checking if "_QQ_"QQ between double quotes"_QQ_" and escaped \"strings\" work. No Package."
PLG_INSTALLER_FOLDERINSTALLER_NO_INSTALL_PATH="Checking if "_QQ_"QQ between double quotes"_QQ_" and escaped \"strings\" work. No folder path."
COM_CONTENTHISTORY_BUTTON_SELECT_ONE="Checking if "_QQ_"QQ between double quotes"_QQ_" and escaped \"strings\" work. Preview and restore."
COM_CONTENTHISTORY_BUTTON_SELECT_TWO="Checking if "_QQ_"QQ between double quotes"_QQ_" and escaped \"strings\" work. Compare."For frontend:
COM_MAILTO_EMAIL_ERR_NOINFO="Checking if "_QQ_"QQ between double quotes"_QQ_" and escaped \"strings\" work. Invalid mail."Testing places:
Extensions Manager->Install
Make sure the field for the Upload Package File tab is empty and click Upload & Install button.
Then Make sure the field for the Install from Folder is empty and click Check and Install button
Content History Modal
In Hathor as well as in Isis, edit an article and Click on the Versions Toolbar button.
Do NOT select any item in the list and click on each button.
Frontend Mailto
Display the Email this link to friend popup. Do not enter anything in the fields and Click on the Send button.
RESULT: for each of these operations, there will be a JS error and the alerts will not display.
PATCH and test again (after clearing all caches)
You should now get all these alerts correctly.
Example:
Documentation Changes Required
None. This is a bug.
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_contenthistory Templates (admin) Front End com_mailto Plugins |
what do you mean with "old style" ?
I have not tested this item.
1. Installer works as always
2. Item Version History. Toolbar buttons show alerts with the message.
3. Email to a Friend does nothing.
Is it OK?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13455.
Let me clarify. The purpose of this PR is to display the language strings value when they contains double quotes.
Before patch, when both en-GB.override.ini —which have been created manually— are present, the double quotes are not escaped correctly, therefore No Alert will display.
For install, it goes even further as the tabs will not display at all.
After patch, for example for install, we will rightfully get:
If you get these results, please mark your test as successful.
@infograf768 the last 2 buttons that I commented about do NOT have the test strings showing.
They do here. You may have to clean cache, check that the back-end en-GB.override.ini is correct or check if the patch was applied correctly.
en-GB.override.ini.zip
I have tested this item
Stopped testing at "Extensions Manager > Install" in Tab
- "Upload Package File"
- and "Install from Folder"
See Screenshot (but Patch works here as tabs are now shown).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13455.
Tested all these 3 cases in the language strings and they do work:
'
\"
"_QQ_"
- Tested versions history modal in article form, applying patch and modifying the language strings
COM_CONTENTHISTORY_BUTTON_SELECT_ONE="Please select ' \" one "_QQ_" version."
COM_CONTENTHISTORY_BUTTON_SELECT_TWO="Please select ' \" two "_QQ_" versions."
JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST="Please ' \" first "_QQ_" make a selection from the list."
- the first 3 button continue to work, further more the escaping in the new way, does not add any unwanted slashes:
Please select ' " one " version
Please select ' " two " versions - the last 2 buttons did not work before patch if you have ' \" "_QQ_" in the language string (no alert instead you get JS error):
after patching you get:
Please ' " first " make a selection from the list.
- Tested Extension Manager / Install / Install From Folder
PLG_INSTALLER_FOLDERINSTALLER_NO_INSTALL_PATH="Please enter ' \"a "_QQ_" Folder."
- with empty folder, the alert message is:
Please enter ' "a " Folder.
- Tested Extension Manager / Install / Upload Package File
PLG_INSTALLER_PACKAGEINSTALLER_NO_PACKAGE="Please select a package ' \" to "_QQ_" upload"
- with no package selected, the alert message is:
Please select a package ' " to " upload.
- Tested Article view / Email Button
COM_MAILTO_EMAIL_ERR_NOINFO="Please provide a ' \" valid email "_QQ_" address."
- with no email in the popup the alert message:
Please provide a ' " valid " email address.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13455.
@franz-wohlkoenig
It looks like you did not create the override.ini manually (or used the zip I posted above) using en-GB as default language.
@infograf768 Sorry, my fault, read not carefully: I made Lang.-Overrides inside Joomla! Will test evening if necessary.
In 3.7.0-alpha1 i copied the downloaded "en-GB.override.ini" to "/administrator/language/en-GB/" cause thinking this is the Place what "On a staging create …" by @infograf768 Test instructions means.
Got String "Please select a package to upload" at "Upload Package File".
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13455.
In 3.7.0-alpha1 i copied the downloaded "en-GB.override.ini" to "/administrator/language/en-GB/" cause thinking this is the Place what "On a staging create …" by @infograf768 Test instructions means.
Nope, the en-GB.override.ini has to go into language/overrides/
and similar place for frontend
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13455.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13455.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-04 19:03:20 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
when testing the buttons in versions "keep on/off" and "Delete" still show old style.