[#13428] - Joomla Update "Find Updates" Issue
- Closed
- 27 Mar 2017
- Medium
- Build: master
- # 13428
Steps to reproduce the issue
Install a load of crap extensions (or just Virtuemart and a load of other crap). Or a site with 100 update sites...
(or be on a crap server that is blocking outgoing traffic in such a way that an outgoing http request hangs instead of getting a connection denied message)
Go to Extensions -> Update -> Find Updates
Note that if any one update site is slow or never ends then the page times out eventually or hangs for ever and ever.
Expected result
Expect a list of updates available
Actual result
Page just hangs because one or more update sites are pathetically slow or dead.
System information (as much as possible)
Joomla 3.6.5
Additional comments
Each update site check should be time boxed, or run in isolation (maybe in a separate ajax thread) so that one doesnt effect all.
joomla-cms-bot
- | Labels |
Added:
?
|
||
Also a time out of 20 seconds per update site... really?
https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/updater/updateadapter.php#L246
Thats far far too long....
reducing the time out to 2 seconds I see the root issue with Virtuemart, however their 404's are just highlighting the root issue in Joomla installer as described in the opening statement of this issue.
| Category | ⇒ | com_installer com_joomlaupdate |
| Status | New | ⇒ | Needs Review |
their 404's are just highlighting the root issue in Joomla installer
@PhilETaylor, what behaviour would you expect instead (beside waiting 2 seconds instead of 20)?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13428.
| Category | com_installer com_joomlaupdate | ⇒ | com_joomlaupdate |
I would expect that all updates would be run in isolation and even maybe in parallel, with individual timeouts, per update, one per http request to avoid timeouts on servers
In J4 we can use promises and chain all these requests, so they would be async and the failures could be handled much better
So there is no appetite to change this behaviour at present?
I'll test the PR if you create it :)
Now where have I heard that before.
Speculative PRs are a waste of time if they are never going to be merged - gauging interest is the best way to start, if there is no interest at the start, there will be no interest in a PR.
This is a big usability bug, I see no reason this issue should not remain open until its fixed.
Nobody's saying it's not an issue. But for those who do PRs, either this isn't an "interesting" issue they want to tackle or they don't have the technical skill set to do anything with it.
or too busy with other
Exactly my point...
Unfortunately Github doesn't have a
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-27 16:10:55 |
| Closed_By | ⇒ | PhilETaylor |
If you keep closing legitimate issues then they're never going to be tackled to begin with.
Im just working through my list of open issues - trying to prune the ones that will never get done, and leaving the ones that might.
Some issues are so big that they will keep cropping up until they are resolved, they dont need an open issue clogging up the Github stats for that...
Its in a book somewhere....
The book is here on GitHub. There isn't a magical list elsewhere of known issues that might get tackled one day if someone is interested.
by book I mean the one by 37Signals
https://gettingreal.37signals.com/ch15_All_Bugs_Are_Not_Created_Equal.php
and in their follow up book they say something about ignoring bug reports that are blatantly obvious because if its really a big enough but it will come back and back and hit you in the face enough that you fix it without users telling you to.
If we were to list all of our annoyances with Joomla in GH then the issues list would be huge ;-)
If we were to list all of our annoyances with Joomla in GH then the issues list would be huge ;-)
That sounds like someone I groan at every time they publish a blog or tweet stream groaning about Joomla performance, they shut up every time I tell them to log an issue instead of groaning
This method needs a lot of reworking https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/updater/updater.php#L115