[#13427] - [Deprecate _QQ_ 2] Save language overrides with escaped double quotes
- Fixed in Code Base
- 4 Jan 2017
- Medium
- Build: staging
- # 13427
- Diff
- andrepereiradasilva:no-qq-override
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
As discussed in #13421
This PR changes language overrides save to ini method so we use escaped double quotes (\") instead of "_QQ_".
Also adds a new method to save the language strings to a ini file so it can be easily used when needed.
Testing Instructions
- Apply patch
- Create a new language override from Extensions -> Languages -> Overrides for the en-GB admin language with some double quotes on it (
"). Save it, load it again and confirm if ok. - Confirm it's saved as escaped double quote in
/administrator/language/overrides/en-GB.override.ini. Example:A test with <a href=\"https://joomla.org\" target=\"_blank\">Joomla</a> - Manually add an override in
/administrator/language/overrides/en-GB.override.iniwith_QQ_and escaped quotes. Example:
JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED="A second test with <a href="_QQ_"https://joomla.org"_QQ_" target=\"_blank\">Joomla</a>"- Confirm language override works
Ex: add to template index.php
// Server side message system
$app->enqueueMessage(JText::_('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED'), 'warning');
// Client side message system (click on the page to show the javascript message)
JText::script('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED');
$this->addScriptDeclaration("document.addEventListener('click', function () { Joomla.renderMessages({'error': [Joomla.JText._('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED')]}) });");
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages Libraries |
I have tested this item
Code review OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13427.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13427.
In any case, can you explain the reason for using addcslashes instead of addslashes ?
warning concerning strings that would be used through js. see my comment in the specific pr.
Is not related to this PR.
In any case, can you explain the reason for using addcslashes instead of addslashes ?
because the only thing to escape are the double quotes ("), ie, the ini string delimiters, the rest AFAIK is allowed in the ini file.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-04 07:19:38 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 56d1bc0
Both
"_QQ_"and\"are being translated as expected and quotes in overrides save as\".This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13427.