Feeling Lucky
?
[#13380] - Clean up ModulesModelModule class
- Fixed in Code Base
- 14 Jan 2017
- Medium
- Build: staging
- # 13380
- Diff
- joomdonation:patch-12
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR make some small changes to ModulesModelModule class:
- Use local $db variable instead of $this->_db
- Use JDatabaseQuery to insert module assignment instead of using plain SQL
- Re-use $query object instead of creating new instance
- Remove one time usage $app variable, call JFactory::getApplication()->redirect directly
Testing Instructions
- Code review
- Access to Extensions -> Modules, click on a module to edit, try to change Module Assignment, make sure it is saved properly.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules |
anibalsanchez
- comment
- 5 Jan 2017
I have tested this item
Code review OK and it works OK assigning modules to menu items.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13380.
joomdonation
- comment
- 6 Jan 2017
@andrepereiradasilva When you have a chance please report your test result for this PR. It is nice to have this abit better code merged.
franz-wohlkoenig
- comment
- 14 Jan 2017
I have tested this item
Test without Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13380.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 14 Jan 2017
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13380.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-14 20:16:14 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 9d65eb4
Code review OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13380.