? Success

User tests: Successful: Unsuccessful:

avatar yvesh
yvesh
27 Dec 2016

Summary of Changes

Added css classes to the mod_login submit buttons. (Testability)

Testing Instructions

Code review

Documentation Changes Required

None

avatar yvesh yvesh - open - 27 Dec 2016
avatar yvesh yvesh - change - 27 Dec 2016
Status New Pending
avatar yvesh yvesh - change - 27 Dec 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 27 Dec 2016
Category Modules Administration Front End
avatar anibalsanchez
anibalsanchez - comment - 5 Jan 2017

I have tested this item successfully on f7fbab2

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13379.

avatar anibalsanchez anibalsanchez - test_item - 5 Jan 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Jan 2017

I have tested this item successfully on f7fbab2

Before Patch:

After Patch:


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13379.
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 14 Jan 2017 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 14 Jan 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 14 Jan 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13379.

avatar wilsonge
wilsonge - comment - 15 Jan 2017

Is there a reason why the classes need to be different for frontend and backend? Secondly from just a pure front-end perspective I'd rather the classes are just login-button (i.e. semantic) rather than containing mod-login which isn't really helpful in anyway

avatar yvesh
yvesh - comment - 15 Jan 2017

@wilsonge i followed the other elements naming scheme in this modules.. No idea why they are that way.

avatar yvesh yvesh - change - 15 Jan 2017
Labels Added: ?
avatar wilsonge wilsonge - change - 15 Jan 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-15 11:56:25
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 Jan 2017
avatar wilsonge wilsonge - merge - 15 Jan 2017

Add a Comment

Login with GitHub to post a comment