? Success

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
23 Dec 2016

Pull Request for Issue #13332.

Summary of Changes

Moves the after title content event output to the right position.

Testing Instructions

  • Create a custom field and set the option to "Automatic Display" to after title
    image

Expected result

The field is shown after the title.

Actual result

The field is shown before the description.

avatar laoneo laoneo - open - 23 Dec 2016
avatar laoneo laoneo - change - 23 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Dec 2016
Category Front End com_content
avatar ggppdk
ggppdk - comment - 23 Dec 2016

Currently, HTML of the events:
-- onContentAfterTitle with an IF !show-intro condition
-- onContentBeforeDisplay
are displayed on the same place, one after the other

So both changes 'onContentAfterTitle' seem right
-- remove the IF !show-intro (and show HTML of onContentAfterTitle events always)
-- move it directly after title inside page-header box

But


1.. About IF !show-intro
-- It is a B/C break ? ... things will start appearing in some sites that were not shown before


2.. About moving HTML of onContentAfterTitle events inside "page header" ?

Yes, if someone uses onContentAfterTitle, instead of onContentBeforeDisplay,
... then the user really means to place it inside the page-header

-- but it is a (smaller) B/C break too, the page header is supposed to contain title and little / less / small stuff like the date
-- and until now it did not contain HTML of "onContentAfterTitle"


I say both changes are correct,
but it should have been like this from the beggining, now they may have unwanted side-effects to existing sites ...

avatar Bakual
Bakual - comment - 23 Dec 2016

It is a B/C break ? ... things will start appearing in some sites that were not shown before

Layouts aren't covered by the B/C promise. See https://developer.joomla.org/cms/development-strategy.html#backward_compatibility

6.1.7 Rendered markup
For the time being, rendered markup is not subject to our backwards compatibility promise. We will try not to change markup in such a way that a site might render differently, but we can't promise not to break anything at the present time.

things will start appearing in some sites that were not shown before

To my knowledge there is no core code that is run in the onContentAfterTitle event. That's probably why nobody noticed this bug yet. So if somethign shows up nw it is coming froma 3rd party plugin and most likely didn't behave as expected before.

avatar ggppdk
ggppdk - comment - 23 Dec 2016

I have tested this item successfully on 871c67f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13345.

avatar ggppdk ggppdk - test_item - 23 Dec 2016 - Tested successfully
avatar laoneo
laoneo - comment - 23 Dec 2016

One question I have, should it be inside or outside the div?
Like that
image

or that
image

avatar ralain
ralain - comment - 23 Dec 2016

Outside. IMO if it's not a part of the title it shouldn't be in the page-header div.

avatar laoneo laoneo - change - 24 Dec 2016
Labels Added: ?
avatar laoneo
laoneo - comment - 24 Dec 2016

Moved the output outside of the page header

avatar ralain
ralain - comment - 24 Dec 2016

I have tested this item successfully on 1543eea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13345.

avatar ralain ralain - test_item - 24 Dec 2016 - Tested successfully
avatar ggppdk
ggppdk - comment - 24 Dec 2016

I have tested this item successfully on 1543eea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13345.

avatar ggppdk ggppdk - test_item - 24 Dec 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 24 Dec 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 24 Dec 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13345.

avatar wilsonge wilsonge - reference | 4498ded - 25 Dec 16
avatar wilsonge wilsonge - merge - 25 Dec 2016
avatar wilsonge wilsonge - close - 25 Dec 2016
avatar wilsonge wilsonge - change - 25 Dec 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-25 19:50:02
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 25 Dec 2016
avatar wilsonge wilsonge - merge - 25 Dec 2016
avatar wilsonge wilsonge - change - 25 Dec 2016
Milestone Added:
avatar laoneo laoneo - head_ref_deleted - 26 Dec 2016

Add a Comment

Login with GitHub to post a comment