See also
#13343

For point 3 see: #13343

Sorry, closed by error.

@cpfeifer can you please look at the UX aspects of this?

@AlexRed can you add one more point in the description: context menus are messed up

I'm just seeing this for the first time and I agree it is confusing. I wasn't entirely sure what was going on until I fiddled around with it for a few minutes.

I agree the editor drag & drop interface / preset builder needs to be separated in some way, maybe a "Configure Editor Layout" tab or something like that.

I'm not entirely sure why the toolbar needs to be seen twice, that really threw me off. There could be a "default" tab in with the presets display, then it only needs to appear once, and the tab labels don't provide much direction. Something like "Preset 1" is much more descriptive.

And I'm also not sure we need all of these options to be selectable via presets, I doubt any of my front end editing clients will ever need to adjust Entity Encoding settings for example. I'd say a handful of the design options should be included, but most of them should remain global.

Aside from the technical issues, I also agree there needs to be consistency from 3.6 and BW compatibility could be an issue. I'd keep the simple, advanced, extended terminology as is.

I'm seeing this for the first time and my first impression is it's more confusing than before. I appreciate the thought put into making the editor interface more flexible, but it will all get lost if no one understands how to use it quickly. I'll dig through the code a bit more and see what I can come up with over the weekend. Happy holidays :)

I feel like I need to answer something, also ?

1. Nope. It is NOT example, it should NOT be hidden. It is a list of available buttons. But YES, would be more helpful to add some Label over that pane, something like "Here is the list of available editor buttons. You can drag&drop them to build your own custom panel". Or even more detailed description, that would be even better. It is an easy change, anyone can do that ?
   Btw, I have tried to write small description how it works there #11926. That can be a base.

2. It is old behavior, I cannot comment here.

3. Please test the fix #13366

4. It made with purpose. Check that comment 11926#issuecomment-246171868 . It is bad if all your users are superusers ?

5. I agree, but it hard to implement.

6. I am not sure. For me "Simple, Advanced, Extended" always was confusing. And "Simple, Medium, Extended" more clear, like 1, 2, 3.

7. It is old behavior, I cannot comment here.

8. Yes it is BC break, but not critical for me. I have noted it in #11926. There no easy way to make FULL migration.

9. Feel free to make the pull request ?

10. Yes, but I think it is not a problem, because see point (8).

11. For me it is fine as it is.

12. This is unclear what did you meant. Can you explain more?

1. add some Label is important also for me

2. where we can comment the old behavior?

3. test ok for me

4. then set by default only one set to Access → Super User

5. :(

6. :(

7. where we can comment the old behavior?

8. this BC break is critical for me because delete all the previous settings by the user, like also Text Filter. To solve it I suggest to not overwrite the actual tinymce plugin but make a new tinymce editor plugin (TinyMCE2 or TinyMCEb or TinyMCEa ecc..) and set it default in the new installation but in the upgrade the user can continue to use the old with all the setting ok.

9. can you help me to do the PR ? Please contact me on Glip

10. see point (8)

11. two parameters with the same identical name is a problem for me. In the documentation is a problem, to help user in the forum is a problem ecc...

12. Please @dgt41 Can you explain more?

where we can comment the old behavior?

I just meant, that I have no idea why it was made like that, so I cannot make comment on these points ?

for point 1, please see #13367

@ everybody
Please scroll below to see a screen that i think it is more easy to understand and configure (please notice the border / padding on the TABs ... and the text ... i kept it to minimal)

@Fedik
About keeping tinyMCE settings of previous Joomla versions,
what about (if it is not too much work ...)

1. A tab "Default layout" (=default set) to load the old configuration
2. And the Custom layouts (=sets) are assigned by default to access "none"
3. And new Joomla installation should have some 4 layouts (sets) that already saved in DB: default, public, registered, special

Thus they are not activated / used, even if user clicks save,
that is unless user ACTIVELY sets an access level** after understanding that something will be effected

This way the "default layout (=old configuration) is both

• continued to be used thus not breaking behaviour of existing sites
• and also acts as a fallback for access levels that do not have a custom layout assigned to them yet

what about (if it is not too much work ...)

It huge amount of work ?
Very hard to make migration of the old toolbar (with all that fancy access check) to new.
But some options can be migrated, like the image path, skin and so on.
This need to think, maybe I do some PR later, but cannot promise much.

About the panels label/description please see #13367.

points 1 and 11 fixed there #13367

see #13367 concerning some changes in this new feature which i think are necessary: b/c and sets used depending on user groups and not access levels.

for BC and access fix please test #13387

5,8,10 fixed in #13387

After the merge:

• The warning message: "The TinyMCE Editor Plugin has been updated. At the moment, it uses your legacy configuration. By editing the plugin, you can now assign various layouts to specific user groups." is visible also in the new installation, i think this message is only for the upgrade.

• If I add a new Set and save it is another "public" access and after "save & close" and re-edit the plugin lost the formatting and the "advanced" TAB.

• for me "Set 0" (Super user) need to be the first TAB (to avoid confusion)

• where can I edit the default "Set 0" setting? I like by default activate also the "Advanced Image" parameter to ensure that at least the administrator is able to insert the margins of the images. And also enable the parameter "Use Joomla Text Filter" so that the administrator can freely insert script in contents.

The warning message: "The TinyMCE Editor Plugin has been updated. At the moment, it uses your legacy configuration. By editing the plugin, you can now assign various layouts to specific user groups." is visible also in the new installation, i think this message is only for the upgrade.

I confirm. The issue comes from the fact that some TinyMCE legacy parameters are set in joomla.sql

(412, 0, 'plg_editors_tinymce', 'plugin', 'tinymce', 'editors', 0, 1, 1, 0, '', '{"mode":"1","skin":"0","mobile":"0","entity_encoding":"raw","lang_mode":"1","text_direction":"ltr","content_css":"1","content_css_custom":"","relative_urls":"1","newlines":"0","invalid_elements":"script,applet,iframe","extended_elements":"","html_height":"550","html_width":"750","resizing":"1","element_path":"1","fonts":"1","paste":"1","searchreplace":"1","insertdate":"1","colors":"1","table":"1","smilies":"1","hr":"1","link":"1","media":"1","print":"1","directionality":"1","fullscreen":"1","alignment":"1","visualchars":"1","visualblocks":"1","nonbreaking":"1","template":"1","blockquote":"1","wordcount":"1","advlist":"1","autosave":"1","contextmenu":"1","inlinepopups":"1","custom_plugin":"","custom_button":""}', '', '', 0, '0000-00-00 00:00:00', 3, 0),

we just need to update the various joomla.sql with the default params.
{"configuration":{"toolbars":{"2":{"toolbar1":["bold","underline","strikethrough","|","undo","redo","|","bullist","numlist","|","pastetext"]},"1":{"menu":["edit","insert","view","format","table","tools"],"toolbar1":["bold","italic","underline","strikethrough","|","alignleft","aligncenter","alignright","alignjustify","|","formatselect","|","bullist","numlist","|","outdent","indent","|","undo","redo","|","link","unlink","anchor","code","|","hr","table","|","subscript","superscript","|","charmap","pastetext","preview"]},"0":{"menu":["edit","insert","view","format","table","tools"],"toolbar1":["bold","italic","underline","strikethrough","|","alignleft","aligncenter","alignright","alignjustify","|","styleselect","|","formatselect","fontselect","fontsizeselect","|","searchreplace","|","bullist","numlist","|","outdent","indent","|","undo","redo","|","link","unlink","anchor","image","|","code","|","forecolor","backcolor","|","fullscreen","|","table","|","subscript","superscript","|","charmap","emoticons","media","hr","ltr","rtl","|","cut","copy","paste","pastetext","|","visualchars","visualblocks","nonbreaking","blockquote","template","|","print","preview","codesample","insertdatetime","removeformat"]}},"setoptions":{"2":{"access":["1"],"skin":"0","skin_admin":"0","mobile":"0","drag_drop":"1","path":"","entity_encoding":"raw","lang_mode":"1","text_direction":"ltr","content_css":"1","content_css_custom":"","relative_urls":"1","newlines":"0","use_config_textfilters":"0","invalid_elements":"script,applet,iframe","valid_elements":"","extended_elements":"","resizing":"1","resize_horizontal":"1","element_path":"1","wordcount":"1","image_advtab":"0","advlist":"1","autosave":"1","contextmenu":"1","custom_plugin":"","custom_button":""},"1":{"access":["6","2"],"skin":"0","skin_admin":"0","mobile":"0","drag_drop":"1","path":"","entity_encoding":"raw","lang_mode":"1","text_direction":"ltr","content_css":"1","content_css_custom":"","relative_urls":"1","newlines":"0","use_config_textfilters":"0","invalid_elements":"script,applet,iframe","valid_elements":"","extended_elements":"","resizing":"1","resize_horizontal":"1","element_path":"1","wordcount":"1","image_advtab":"0","advlist":"1","autosave":"1","contextmenu":"1","custom_plugin":"","custom_button":""},"0":{"access":["7","4","8"],"skin":"0","skin_admin":"0","mobile":"0","drag_drop":"1","path":"","entity_encoding":"raw","lang_mode":"1","text_direction":"ltr","content_css":"1","content_css_custom":"","relative_urls":"1","newlines":"0","use_config_textfilters":"0","invalid_elements":"script,applet,iframe","valid_elements":"","extended_elements":"","resizing":"1","resize_horizontal":"1","element_path":"1","wordcount":"1","image_advtab":"0","advlist":"1","autosave":"1","contextmenu":"1","custom_plugin":"","custom_button":""}}},"sets_amount":3,"html_height":"550","html_width":"750"}

Please test #13431

If I add a new Set and save it is another "public" access and after "save & close" and re-edit the plugin lost the formatting and the "advanced" TAB.

I confirm. This is a bug.
@Fedik Can you look into this?
Looks like this is a js error val is null in tinymce-builder.js line 302-303

for (var i = 0, l = val.length; i < l; i++ ) {
                    if (!val[i]) continue;
                    query.push('[value="' + val[i] + '"]');
                }

The issue comes from the fact that some TinyMCE legacy parameters are set in joomla.sql

I think we can remove the default parameters from SQL, it already handled by the code https://github.com/joomla/joomla-cms/blob/staging/plugins/editors/tinymce/tinymce.php#L402 and in other places eg $levelParams->get('content_css', 1) and so on.

And about another bug I will check

If I add a new Set and save it is another "public" access and after "save & close" and re-edit the plugin lost the formatting and the "advanced" TAB.

please test #13434

#13431 #13434 Tested successfully

Can we change the warning message? It is not clear that all your 'legacy settings" will be lost the moment you change settings. We might have a warning such as

The TinyMCE Editor Plugin has been updated. At the moment, it uses your legacy configuration. By editing the sets of the TinyMCE panel plugin, you can now assign various layouts to specific user groups but be aware that with editing you will need to redo all settings in the plugin

I agree

In Joomla 3.6.5 if the editor TinyMCE is set "Functionality"-->"Extended" in the TinyMCE “Insert/Edit Image” Dialogue you can see the "Advanced" tab and set the image margin. In Joomla 3.7.0 the TinyMCE editor is set by default in "Extended" mode but the "Advanced Image" parameter is set "Off" by default for the administrator and the TAB "Advanced" is not visible.

Please, please, please also enable by default "Advanced Image" parameter for Administrator, to set the margin in the image in TinyMCE “Insert/Edit Image” Dialogue

See #13897