Feeling Lucky
?
[#13297] - Few changes in installation
- Fixed in Code Base
- 25 Dec 2016
- Medium
- Build: staging
- # 13297
- Diff
- frankmayer:few-changes-in-installation
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Unnecessary double quotes
dirname()to__DIR__- Optimized loop termination condition
- Short syntax for applied operation
- Remove one-time-use variable
- Remove superfluous property initialization
The changes in this PR should be fairly easy to review. In hope that this will get merged quickly so further work can be done without conflicting with other PRs. ;)
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Labels |
Added:
?
|
||
shur
- comment
- 25 Dec 2016
I have tested this item
Code Review.
I approve it here ( https://issues.joomla.org ) because approval on github doesn't count for some unknown reason.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13297.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 25 Dec 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13297.
| Milestone |
Added: |
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-25 20:47:16 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on a12727e
Done code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13297.