[#13296] - Further work on layouts
- Fixed in Code Base
- 27 Dec 2016
- Medium
- Build: staging
- # 13296
- Diff
- frankmayer:further-work-on-layouts
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Unnecessary parentheses
- Ternary operator simplification and type safe comparison
- Use elvis!
- Type-casting instead of strVal()
- Replace isArray()... with type-cast
The changes in this PR are only a few and should be fairly easy to review. In hope that this will get merged quickly so further work can be done without conflicting with other PRs. ;)
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
@jeckodevelopment i asked how should i mark this code reviews on JBS channel.
I'm not doing tests, just code review, so marked as code review as instructed in that channel.
I have tested this item
I can mark a successful test on this one, on careful code review ... due to little changes involve
The unneeded parenthesis,
also the 2 type of typecasts done, are safe modifications, no problem with PHP 5.3
but i have not installed the patch to run any tests
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13296.
But some other PRs have too many changes, i would not feel good to mark a successful test on code review only
Maybe there should be something like with 3 or 4 code reviews set to RTC ? I don't know
@ggppdk Yes, some of those batch PR's were huge with lots of different changes. That is why I have made compartmentalized sub-PR's to lighten the batch PR's up and be finally easier to review/test and finally merge them. The sub PR's are referenced in the batch-PR's and vice versa.
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13296.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13296.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-27 21:50:33 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@ggppdk and @andrepereiradasilva can you please continue using tests as usual?