[#13276] - Type safe comparison in libraries/cms - second iteration
- Fixed in Code Base
- 13 Jun 2017
- Medium
- Build: staging
- # 13276
- Diff
- frankmayer:tye-safety-in-libraries-cms-2
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Type safe comparison in libraries/cms - second iteration
- some bool
- some int
This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for the libraries/cms directory, which is still on hold (#12171).
Once the new set is merged completely, it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.
The changes in this PR should be also be fairly easy to review. In hope that this will get merged quickly. ;)
Note: Don't bother if some possible changes are missing or could be differently written. They are probably in the batch PR , that this one references. As soon as this set of sub PR's is merged, the batch PR will have its conflicts resolved and should be a lot easier to review and finally get merged.
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
@andrepereiradasilva & @Quy Would you be so nice to code review this, too. So we can RTC this and after merging, tackle the parent PR (when all its Sub PRs are merged)? Again, thank you for your efforts!!
I have tested this item
code review and according to comments above
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13276.
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13276.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-13 13:19:59 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Conflicts resolved. Pls check and merge.