[#13275] - Type safe comparison of strings only, in libraries/cms
- Fixed in Code Base
- 13 Jun 2017
- Medium
- Build: staging
- # 13275
- Diff
- frankmayer:type-safety-in-libraries-cms
- Success hound No violations found. Woof! Details
- Pending continuous-integration/appveyor/pr Waiting for AppVeyor build to complete Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Type safe string comparison of strings only, in libraries/cms
This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for the libraries/cms directory, which is still on hold (#12171).
Once the new set is merged completely, it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.
The changes in this PR should be very easy to review, as they are only string and string type comparisons. In hope that this will get merged quickly. ;)
Note: Don't bother if some possible changes are missing or could be differently written. They are probably in the batch PR , that this one references. As soon as this set of sub PR's is merged, the batch PR will have its conflicts resolved and should be a lot easier to review and finally get merged.
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
Conflicts resolved. Pls check and merge.
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13275.
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13275.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-13 14:27:35 |
| Closed_By | ⇒ | rdeutz |
Conflicts resolved...