[#13260] - Link field for the full-article-image.
- Closed
- 30 Jun 2019
- Medium
- Build: staging
- # 13260
- Diff
- bonzani:staging
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR adds a modal link field that can be used to specify an url along with the title and rel attributes and uses it to provide an optional link for the full article image. This is very useful if a lightbox for images is used.
Testing Instructions
- Open the edit view of some article with a full article image in the backend.
- Click on select next to the new field "Full image link"
- Insert some values in the modal window.
- Click save and also save the article.
- Check if the article image in the frontend is now surrounded by the specified link with the according attributes.
Documentation Changes Required
Add the new link field to the documentation.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Language & Strings Layout Libraries |
| Labels |
Added:
?
?
|
||
| Category | Administration com_content Language & Strings Layout Libraries | ⇒ | Administration com_content Language & Strings Layout Libraries JavaScript |
I have tested this item
I preferred "Full Image Link" instead of "Full image link" as title and as description.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13260.
While this works, I don't think it's such a great idea for core. It sounds more like something which could be achieved with the new custom fields feature and a layout override.
Beside that, there are some UX issues with it.
There is no indication in the field that there is something set. You need to open the modal for it.
The modal itself is actually not needed, better do all in the article form. Using showon, you can show the additional fields if needed. So I would ditch the modal.
The new fields in the modal also would need some tooltips/descriptions.
I have tested this item successfully
It is a good idea to make images clickable.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13260.
| Category | Administration com_content Language & Strings Layout Libraries JavaScript | ⇒ | Administration com_content JavaScript Layout Libraries |
Hi @bonzani,
this PR will not be merged in to J3.x because of the feature freeze we have, I'm also not confident how this "problem" is solved. For me it looks a bit overengineered for a simple link.
Anyway if you like to add this to core you should create a RFC issue and maybe rebase your PR for J4.
thx for you work and time to improve Joomla!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-30 22:27:11 |
| Closed_By | ⇒ | HLeithner |
| Category | Administration com_content Layout Libraries JavaScript | ⇒ | Administration com_content Language & Strings Layout Libraries JavaScript |
I have tested this item✅ successfully on ffa4313
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13260.