[#13258] - Remove callable calls from loop termination condition, project wide
- Fixed in Code Base
- 13 Jun 2017
- Medium
- Build: staging
- # 13258
- Diff
- frankmayer:remove-callable-calls-from-loop-termination-condition
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Remove callable calls from loop termination condition. Will speed up those loops.
Note. There has been no foreach conversion on purpose, This might take place for some of those, in another PR.
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate com_templates Templates (admin) Front End com_content Installation Libraries Postgresql Plugins Unit Tests |
| Labels |
Added:
?
?
|
||
| Category | Administration com_joomlaupdate com_templates Templates (admin) Front End com_content Installation Libraries Postgresql Plugins Unit Tests | ⇒ | Administration com_templates Templates (admin) Front End com_content Installation Libraries Postgresql Plugins Unit Tests |
| Category | Administration com_templates Templates (admin) Front End com_content Installation Libraries Postgresql Plugins Unit Tests | ⇒ | Administration com_templates Templates (admin) Libraries Postgresql Front End Plugins |
I have tested this item
On code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13258.
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13258.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-13 13:15:21 |
| Closed_By | ⇒ | rdeutz |
@frankmayer would you be willing to do this to the framework database package here https://github.com/joomla-framework/database so it's included in the 4.0 branch please
@wilsonge done: joomla-framework/database#95 and joomla-framework/database#96
Don't know if both are needed. I saw what seems to be the 1.x line and also the 2.x-dev, so I thought I'd do the PR changes against both...
I have tested this item✅ successfully on 388ab4f
Code review OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13258.