Joomla! Issue Tracker | Joomla! CMS #13257 - Convert `call_user_func` and `call_user_func_array` to variable functions, project wide

Fixed in Code Base
13 Jun 2017
Medium
Build: staging
# 13257
Diff
frankmayer:do-not-use-call-user-func

Success

Success hound No violations found. Woof! Details
Success continuous-integration/drone/pr the build was successful Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

frankmayer
18 Dec 2016

Summary of Changes

Convert call_user_func and call_user_func_array to variable functions, which are about four times faster and also easier to read.

Testing Instructions

Code review only, should not change behavior

Documentation Changes Required

None.

07c26c5 18 Dec 2016

Convert `call_user_func` and `call_user_func_array` to variable functions

frankmayer - open - 18 Dec 2016

frankmayer - change - 18 Dec 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 18 Dec 2016

Category

⇒

Administration com_categories com_tags Repository Libraries Postgresql MS SQL Front End Plugins

3d8a82b 18 Dec 2016

Fix `Call-time pass-by-reference has been removed`

frankmayer - change - 18 Dec 2016

Labels

Added: ?

26e94d5 18 Dec 2016

Fix `Call-time pass-by-reference has been removed`. This time all of them.

andrepereiradasilva - comment - 18 Dec 2016

i add some doubts about this one, so applied the patch
Content -> Categories

An error has occurred.
0 Call to a member function addSubmenu() on string
Call stack
#	Function	Location
1	JApplicationCms->execute()	/path/to/joomla-staging/administrator/index.php:51
2	JApplicationAdministrator->doExecute()	/path/to/joomla-staging/libraries/cms/application/cms.php:265
3	JApplicationAdministrator->dispatch()	/path/to/joomla-staging/libraries/cms/application/administrator.php:152
4	JComponentHelper::renderComponent()	/path/to/joomla-staging/libraries/cms/application/administrator.php:98
5	JComponentHelper::executeComponent()	/path/to/joomla-staging/libraries/cms/component/helper.php:376
6	require_once()	/path/to/joomla-staging/libraries/cms/component/helper.php:401
7	JControllerLegacy->execute()	/path/to/joomla-staging/administrator/components/com_categories/categories.php:27
8	CategoriesController->display()	/path/to/joomla-staging/libraries/legacy/controller/legacy.php:707
9	CategoriesHelper::addSubmenu()	/path/to/joomla-staging/administrator/components/com_categories/controller.php:94

Using php 7.1 if relevant

frankmayer - comment - 18 Dec 2016

Hmm, going to check, thanks.

7289587 18 Dec 2016

PHP 5.3 B/C break bit us here... revert (also in some cases the proposed change was wrong :( )

joomla-cms-bot - change - 18 Dec 2016

Category

Administration com_categories com_tags Repository Libraries Postgresql MS SQL Front End Plugins

⇒

Libraries Postgresql MS SQL Front End Plugins

frankmayer - comment - 25 Dec 2016

@andrepereiradasilva the issue, you were seeing, shoudl be resolved now. Thanks!