Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13254] - Remove false param on fetching form data

? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
17 Dec 2016

Pull Request for Issue #13231, #13218

Summary of Changes

For some odd reason that I don't care to debug at this point instructing the user registration model to load a registration form without data cause the form structure to be completely busted and not correctly respect the structure changes made by the profile plugin in onContentPrepareForm. Loading it with data makes it work right. So, accept this hack.

Testing Instructions

User registration works correctly, the profile plugin definitions are respected.

Documentation Changes Required

N/A

avatar mbabker mbabker - open - 17 Dec 2016
avatar mbabker mbabker - change - 17 Dec 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Dec 2016
Category ⇒ Front End com_users
avatar infograf768
infograf768 - comment - 18 Dec 2016

we have a cs issue for Travis although it does not concern this PR.

avatar zero-24
zero-24 - comment - 18 Dec 2016

@mbabker i have updated your branch as the CS fix should be fixed by #13255

avatar zero-24 zero-24 - change - 18 Dec 2016
Labels Added: ?
avatar infograf768
infograf768 - comment - 18 Dec 2016

I have tested this item ✅ successfully on c2ee753

this corrects the display of the profile ´required' fields.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13254.

avatar infograf768 infograf768 - test_item - 18 Dec 2016 - Tested successfully
avatar gwsdesk
gwsdesk - comment - 19 Dec 2016

I have tested this item ✅ successfully on c2ee753

Works for me like a charm

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13254.

avatar gwsdesk gwsdesk - test_item - 19 Dec 2016 - Tested successfully
avatar infograf768 infograf768 - change - 19 Dec 2016
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 19 Dec 2016

RTC. Thanks.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13254.

avatar Bakual Bakual - change - 19 Dec 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-12-19 07:34:00
Closed_By ⇒ Bakual
Labels Added: ?
avatar Bakual Bakual - close - 19 Dec 2016
avatar Bakual Bakual - merge - 19 Dec 2016
avatar Bakual Bakual - reference | 3722260 - 19 Dec 16
avatar Bakual Bakual - merge - 19 Dec 2016
avatar Bakual Bakual - close - 19 Dec 2016
avatar Bakual Bakual - change - 19 Dec 2016
Milestone Added:
avatar Spudley
Spudley - comment - 19 Dec 2016

I'm pleased to see that this has been resolved. Thank to @mbabker and everyone else involved.

Since this bug would affect anyone using the User Profile plugin who moves to 3.6.5, may I suggest that it might be worthwhile adding a note about it on the FAQ page about the 3.6.5 release. Thank you. :)

avatar infograf768
infograf768 - comment - 19 Dec 2016

Since this bug would affect anyone using the User Profile plugin who moves to 3.6.5, may I suggest that it might be worthwhile adding a note about it on the FAQ page about the 3.6.5 release.

Please do.

avatar mbabker mbabker - head_ref_deleted - 19 Dec 2016
avatar cpfeifer cpfeifer - reference | fb3e6ba - 22 Dec 16

Add a Comment

Login with GitHub to post a comment