?
avatar webman85
webman85
17 Dec 2016

Steps to reproduce the issue

Please provide as the user to choose the option to remove or not tags.

I read the forums, it gives a lot of inconvenience.

Expected result

Actual result

System information (as much as possible)

Additional comments

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar webman85 webman85 - open - 17 Dec 2016
avatar joomla-cms-bot joomla-cms-bot - labeled - 17 Dec 2016
avatar zero-24
zero-24 - comment - 17 Dec 2016

I have read your report twice now and i have no idea what do you want or what do you mean. Can you please explain or show (e.g. screenshot) what is wrong and what do you want us to change?

Thanks

avatar webman85
webman85 - comment - 17 Dec 2016

now function include
public static function _cleanIntrotext($introtext)
{
$introtext = str_replace('<p>', ' ', $introtext);
$introtext = str_replace('</p>', ' ', $introtext);
$introtext = strip_tags($introtext, '<a><em><strong>');
$introtext = trim($introtext);
return $introtext;
}

i want change on

$introtext = strip_tags($introtext, '<a><em><strong><img><div><span><br>');

because after all update resets

avatar zero-24
zero-24 - comment - 17 Dec 2016

Hmm it looks like the importend part is missing (github cuted them out :) can you please told us which tags you want to filter with strip_tags?

avatar webman85
webman85 - comment - 17 Dec 2016

No, I want to cancel the filter or change the filter options.

avatar zero-24
zero-24 - comment - 17 Dec 2016

Why do you want to have img div span and br tag in there? As it is a module i think it would be a mess with the tags in there (e.g. A image one a module position in the intro text may break the layout same for div and br. For span i'm not sure i think this can be added as i can't see any issues with that.

Can you show us examples where this tags (e.g. img div and br) are useful to use in that context?

avatar webman85
webman85 - comment - 17 Dec 2016

http://unik.place-testing.ru/ for print all objects on front page
if I can use my desired tags will not have problems with the layout for different devices

I agree that it is sometimes necessary to display a text, but the use of the module in this embodiment is also very convenient and does not require the invention of crutches

it would be nice to give the possibility to determine the necessary tags from the admin panel for this module

avatar Bakual
Bakual - comment - 17 Dec 2016

I don't really understand your request, but wonder if you can't achieve what you want with a template override or another template style (eg "none" adds nothing around the output).

avatar sovainfo
sovainfo - comment - 18 Dec 2016

The request is very simple. Whatever is stripped should be configurable at the module instead of hardcoded!

No, that is not something you can do with overrides or style. It would require a clone.

avatar ggppdk
ggppdk - comment - 18 Dec 2016

The request is very simple. Whatever is stripped should be configurable at the module instead of hardcoded!

The usage of method _cleanIntrotext(), should be moved to be inside the template / layout files and not inside the code of the Module Helper class

But before the above is done,

  • the above mentioned method should be replaced by an API method living inside StringHelper class, to do things done by _cleanIntrotext(), but with more flexible configuration

thus it will be reusable to more places

avatar Bakual
Bakual - comment - 18 Dec 2016

You probably can't just move it to the layouts because it would break existing overrides.
But you can store the raw introtext into a $item->introtextRaw before cleaning it. Then an override could use that and do its own cleaning instead.

avatar pdreyn
pdreyn - comment - 22 Dec 2016

I am looking to do the same (change the tags that are allowed in introtext). Forgive what may be a naive question, but is the comment:

"But you can store the raw introtext into a $item->introtextRaw before cleaning it. Then an override could use that and do its own cleaning instead."

a suggestion for how helper.php should be enhanced, or is there some way to do so ( store the raw introtext into a $item->introtextRaw ) as an override within a template?

avatar Bakual
Bakual - comment - 22 Dec 2016

You need to do that in the helper.

avatar pdreyn
pdreyn - comment - 22 Dec 2016

So second stupid question. Is there a way to override the existing helper.php or do I need to create a new module?

avatar Bakual
Bakual - comment - 22 Dec 2016

No, there is no way. Either copy the module or submit a PR to change the existing one.
See https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

avatar pdreyn
pdreyn - comment - 22 Dec 2016

thx.

avatar joomla-cms-bot joomla-cms-bot - edited - 22 Dec 2016
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 May 2017
Status New Discussion
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2017
Title
mod_articles_category -> helper.php -> delete function _cleanIntrotext
mod_articles_category -> helper.php -> delete function _cleanIntrotext
avatar anjahage
anjahage - comment - 3 Jun 2017

@webman85 Is this issue still relevant?

Otherwise @nibra will look at it


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13253.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Jun 2017
Status Discussion Information Required
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Jun 2017

set Status on "Information Required".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13253.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Jun 2017

If this PR get no Response, it will be closed at 23th July 2017.

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Jul 2017
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2017-07-23 08:33:17
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2017
Closed_Date 2017-07-23 08:33:17 2017-07-23 08:33:18
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 23 Jul 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 23 Jul 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Jul 2017

closed as stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13253.

Add a Comment

Login with GitHub to post a comment