?
?
Success
-
Success
continuous-integration/drone
the build was successful
Details
-
Success
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
User tests:
Successful:
Unsuccessful:
Summary of Changes
- Removed unused or immediately overwritten variables
- Removed unused or immediately overwritten variables in tests
- Commented out some reference code, as it is not used in that scope
- Not sure on one prospect removal. Added a TODO.
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
frankmayer
-
open
-
14 Dec 2016
frankmayer
-
change
-
14 Dec 2016
joomla-cms-bot
-
change
-
14 Dec 2016
Category |
|
⇒ |
Administration
com_admin
com_config
com_contact
com_content
com_installer
com_modules
com_newsfeeds
com_tags
com_templates
com_users
Front End
Libraries
External Library
Plugins
Unit Tests
|
frankmayer
-
change
-
14 Dec 2016
joomla-cms-bot
-
change
-
14 Dec 2016
Category |
Administration
com_admin
com_config
com_contact
com_content
com_installer
com_modules
com_newsfeeds
com_tags
com_templates
com_users
Front End
Libraries
External Library
Plugins
Unit Tests
|
⇒ |
Administration
com_admin
com_config
com_contact
com_content
com_installer
com_modules
com_newsfeeds
com_tags
com_templates
com_users
Front End
Libraries
Plugins
Unit Tests
|
andrepereiradasilva
-
test_item
-
14 Dec 2016
-
Tested successfully
anibalsanchez
-
test_item
-
18 Dec 2016
-
Tested successfully
jeckodevelopment
-
change
-
18 Dec 2016
Status |
Pending |
⇒ |
Ready to Commit |
Labels |
|
jeckodevelopment
-
change
-
18 Dec 2016
rdeutz
-
merge
-
21 Dec 2016
rdeutz
-
close
-
21 Dec 2016
Status |
Ready to Commit |
⇒ |
Fixed in Code Base |
Closed_Date |
0000-00-00 00:00:00 |
⇒ |
2016-12-21 22:01:36 |
Closed_By |
|
⇒ |
rdeutz |
rdeutz
-
close
-
21 Dec 2016
rdeutz
-
merge
-
21 Dec 2016
Add a Comment
Login with GitHub to post a comment
I have tested this item✅ successfully on be41cd6
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13206.