? ? Success

User tests: Successful: Unsuccessful:

avatar frankmayer
frankmayer
14 Dec 2016

Summary of Changes

  • Removed unused or immediately overwritten variables
  • Removed unused or immediately overwritten variables in tests
  • Commented out some reference code, as it is not used in that scope
  • Not sure on one prospect removal. Added a TODO.

Testing Instructions

None, should not change behavior

Documentation Changes Required

None.

avatar frankmayer frankmayer - open - 14 Dec 2016
avatar frankmayer frankmayer - change - 14 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Dec 2016
Category Administration com_admin com_config com_contact com_content com_installer com_modules com_newsfeeds com_tags com_templates com_users Front End Libraries External Library Plugins Unit Tests
avatar frankmayer frankmayer - change - 14 Dec 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Dec 2016
Category Administration com_admin com_config com_contact com_content com_installer com_modules com_newsfeeds com_tags com_templates com_users Front End Libraries External Library Plugins Unit Tests Administration com_admin com_config com_contact com_content com_installer com_modules com_newsfeeds com_tags com_templates com_users Front End Libraries Plugins Unit Tests
avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Dec 2016

I have tested this item successfully on be41cd6

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13206.

avatar andrepereiradasilva andrepereiradasilva - test_item - 14 Dec 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 18 Dec 2016

I have tested this item successfully on be41cd6

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13206.

avatar anibalsanchez anibalsanchez - test_item - 18 Dec 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 18 Dec 2016
Status Pending Ready to Commit
Labels
avatar jeckodevelopment
jeckodevelopment - comment - 18 Dec 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13206.

avatar jeckodevelopment jeckodevelopment - change - 18 Dec 2016
Milestone Added:
avatar rdeutz rdeutz - change - 21 Dec 2016
Labels Added: ?
avatar rdeutz rdeutz - reference | cce201a - 21 Dec 16
avatar rdeutz rdeutz - merge - 21 Dec 2016
avatar rdeutz rdeutz - close - 21 Dec 2016
avatar rdeutz rdeutz - change - 21 Dec 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-21 22:01:36
Closed_By rdeutz
avatar rdeutz rdeutz - close - 21 Dec 2016
avatar rdeutz rdeutz - merge - 21 Dec 2016
avatar cpfeifer cpfeifer - reference | fb3e6ba - 22 Dec 16
avatar frankmayer frankmayer - head_ref_deleted - 25 Dec 2016

Add a Comment

Login with GitHub to post a comment